[@typespec/spector] - Enable Multiple Scenario Paths #4836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarangan12
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
sarangan12
commented
Oct 23, 2024
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
sarangan12
force-pushed
the
MultipleScenarios
branch
from
43c78aa
to
6e374ba
Compare
timotheeguerin
approved these changes
Oct 25, 2024
github-merge-queue bot
pushed a commit
to Azure/typespec-azure
that referenced
this pull request
Oct 29, 2024
#1753) This is the azure specific counter part of the PR microsoft/typespec#4836. In this PR, the `azure-http-specs` package is being rolled out. Please review and approve the PR. Thanks
swatkatz
pushed a commit
to swatkatz/typespec
that referenced
this pull request
Nov 5, 2024
Currently we could execute the `serve`/`server-test`/... command such as: `pnpm .\cmd\cli.mjs serve ..\http-specs\specs` i.e we could provide only one path of scenarios to execute. But, since we separated the scenarios to azure and non-azure specific cases to 2 different packages, we need a way to execute commands such as: `pnpm .\cmd\cli.mjs serve ..\http-specs\specs ..\..\..\typespec-azure\packages\azure-http-specs\specs\` The same procedure must be followed in all other commands such as `validate-scenarios`, `generate-scenarios-summary`, etc. Since we have to do it for all the commands and we need to change in all the places, it is much simpler to do it in one location where we copy the files to one common temp location and execute from there. Also, in this PR, I have removed the `private: true` option for all the 5 packages to start the rollout process. Please review and approve the PR. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we could execute the
serve/server-test/... command such as:pnpm .\cmd\cli.mjs serve ..\http-specs\specsi.e we could provide only one path of scenarios to execute. But, since we separated the scenarios to azure and non-azure specific cases to 2 different packages, we need a way to execute commands such as:
pnpm .\cmd\cli.mjs serve ..\http-specs\specs ..\..\..\typespec-azure\packages\azure-http-specs\specs\The same procedure must be followed in all other commands such as
validate-scenarios,generate-scenarios-summary, etc. Since we have to do it for all the commands and we need to change in all the places, it is much simpler to do it in one location where we copy the files to one common temp location and execute from there.Also, in this PR, I have removed the
private: trueoption for all the 5 packages to start the rollout process.Please review and approve the PR. Thanks