Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate Namespace mutation to its types #4937

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Propagate Namespace mutation to its types #4937

merged 4 commits into from
Nov 6, 2024

Conversation

joheredi
Copy link
Member

@joheredi joheredi commented Nov 1, 2024

  • Expose mutateSubgraphWithNamespace which allows Namespace mutations
  • mutateSubgraph doesn't allow Namespace mutators. We want to keep namespace mutator hidden as it is a more advanced use case.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 1, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/compiler
Show changes

@typespec/compiler - feature ✏️

Add mutateSubgraphWithNamespace as a separate API

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

timotheeguerin
timotheeguerin approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@timotheeguerin timotheeguerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit for now

@joheredi joheredi enabled auto-merge November 6, 2024 02:02
@joheredi joheredi added this pull request to the merge queue Nov 6, 2024
Merged via the queue into microsoft:main with commit afd8945 Nov 6, 2024
22 checks passed
@joheredi joheredi deleted the feature/mutate-namespaces-cascade branch November 6, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joheredi @azure-sdk @timotheeguerin