Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[http-spec] add link case of server driven pagination test #5211

Merged
merged 8 commits into from
Nov 28, 2024
Merged

[http-spec] add link case of server driven pagination test #5211

merged 8 commits into from
Nov 28, 2024

Conversation

tadelesh
Copy link
Member

only cover next link scenario for pagination. more complex case could be added later.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 27, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/http-specs
Show changes

@typespec/http-specs - feature ✏️

add link case of server driven pagination test

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

weidongxu-microsoft
weidongxu-microsoft reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@weidongxu-microsoft weidongxu-microsoft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the scenario.

Unsure the location. For azure it is https://github.com/Azure/typespec-azure/tree/main/packages/azure-http-specs/specs/payload/pageable

@msyyc
Copy link
Contributor

msyyc commented Nov 28, 2024

LGTM for the scenario.

Unsure the location. For azure it is https://github.com/Azure/typespec-azure/tree/main/packages/azure-http-specs/specs/payload/pageable

I think we shall try to make the position same as much as possible between these 2 specs. @tadelesh

@tadelesh
Copy link
Member Author

i think current azure test under specs/payload/pageable is duplicated with specs/azure/core/page. shall we remove the formal one?

@msyyc
Copy link
Contributor

msyyc commented Nov 28, 2024 •
edited
Loading

specs/azure/core/page only for azure and specs/payload/pageable could be for azure or unbranded I understand.

i think current azure test under specs/payload/pageable is duplicated with specs/azure/core/page. shall we remove the formal one?

@msyyc msyyc closed this Nov 28, 2024
@msyyc msyyc reopened this Nov 28, 2024
@weidongxu-microsoft
Copy link
Contributor

weidongxu-microsoft commented Nov 28, 2024 •
edited
Loading

i think current azure test under specs/payload/pageable is duplicated with specs/azure/core/page. shall we remove the formal one?

I think it is by Pan.

I am fine to remove that (or move it to azure folder)

@tadelesh
Copy link
Member Author

sync with weidong. i moved tests to payload and weidong will move the azure test to azure folder.

@tadelesh tadelesh enabled auto-merge November 28, 2024 06:21
@tadelesh tadelesh added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit b6dcb04 Nov 28, 2024
23 checks passed
@tadelesh tadelesh deleted the list_operation_test branch November 28, 2024 11:50
archerzz pushed a commit to archerzz/typespec that referenced this pull request Dec 17, 2024
@tadelesh
[http-spec] add link case of server driven pagination test (microsoft…
cb97a0f 
…#5211)

only cover next link scenario for pagination. more complex case could be
added later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tadelesh @azure-sdk @msyyc @weidongxu-microsoft