Skip to content

Conversation

@dthaler
Copy link
Contributor

@dthaler dthaler commented Aug 22, 2023

No description provided.

Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Copy link
Contributor

@nibanks nibanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. General question though: Can/should we move stuff to be header only (via macros or possibly inline functions) instead of functions defined in separate files? Ideally the linker should do a good job of eliminating overhead, but it doesn't always do it perfect.

@dthaler
Copy link
Contributor Author

dthaler commented Aug 22, 2023

LGTM. General question though: Can/should we move stuff to be header only (via macros or possibly inline functions) instead of functions defined in separate files? Ideally the linker should do a good job of eliminating overhead, but it doesn't always do it perfect.

The downside of macros/inlines is that if they're non-trivial and used a lot, then they can increase the footprint and memory requirements. So I would say: yes for trivial functions, no for complex functions. Can do a pass in a separate PR.

@dthaler dthaler merged commit b43a417 into main Aug 22, 2023
@dthaler dthaler deleted the size branch August 22, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants