Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate project: add option to set the nuget package name #111

Conversation

autoantwort
Copy link
Contributor

Currently the name is based on the path of the current vcpkg root, but if you want to commit
the project integration, you have the problem that the package name is different on every
developer machine. So add an option to set the package name.

Currently the name is based on the path of the current vcpkg root, but if you want to commit
the project integration, you have the problem that the package name is different on every
developer machine. So add an option to set the package name.
@ras0219-msft
Copy link
Contributor

The package contents hardcode the full path to the vcpkg instance on the machine, so vcpkg integrate project is not able to be used cross-machine regardless of the package id. For users that want behavior like vcpkg integrate project cross machine, they should instead use a submodule and directly pull in the props/targets.

@autoantwort
Copy link
Contributor Author

Hm I see. We actually use vcpkg as a submodule. Maybe vcpkg can simply provide a property sheet that can be added to a project. For me that actually sounds cleaner that the nuget way.

@ras0219-msft
Copy link
Contributor

We do!

scripts\buildsystems\msbuild\vcpkg.props and scripts\buildsystems\msbuild\vcpkg.targets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants