-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teach vcpkg fetch to handle msi files #117
Teach vcpkg fetch to handle msi files #117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if 7z is already installed?
Does this make it show up in add/remove programs?
No, From https://docs.microsoft.com/en-us/windows/win32/msi/administrative-installation:
Which is clear as mud, but basically my understanding is that you could use the administrative install to eventually perform a full machine install later. |
OK, I'm convinced. Approve-with-suggestion to add that test |
This PR adds
.msi
support tovcpkg fetch
in order to enable upgrading 7zip to a more recent version (19.00). We must use the MSI package because it is one of the few formats that can be supported on a completely stock Windows machine.Once this change is applied, we'll replace the 7zip entry in
vcpkgTools.xml
with:As a side benefit, this allows us to use 7zip to unpack
.nupkg
files in the future, since we will no longer require nuget to unpack 7zip.