add VCPKG_POST_PORTFILE_INCLUDES #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Neumann-A
commented
Jun 9, 2024
Neumann-A
commented
Jun 9, 2024
| for (size_t i = 0; i < abi_info.pre_build_info->post_portfile_includes.size(); ++i) | ||
| { | ||
| auto& file = abi_info.pre_build_info->post_portfile_includes[i]; | ||
| if (file.is_relative() || !fs.is_regular_file(file) || file.extension() != ".cmake") |
There was a problem hiding this comment.
should the extensions check be dropped? CMake can include arbitrary files and if it is not in cmake syntax, cmake will complain about it.
There was a problem hiding this comment.
I like the idea of requiring CMake for now; if someone complains we could always relax it later, but once shipped we can't strengthen it.
BillyONeal
approved these changes
Jul 24, 2024
|
Thank you! |
|
Sorry, I normally wouldn't push even nitpick fixes like that into your PR unless I was going to merge the thing; just as I was doing that I noticed the comment in the other PR ( microsoft/vcpkg#25847 (review) ) This looks good to me and I asked Victor to OK it. |
|
@BillyONeal I don't mind. If I would mind I could disable the checkbox allowing you to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs pr: microsoft/vcpkg-docs#336
vcpkg pr: microsoft/vcpkg#25847