Preserve the full exit code range in the system.process layer. #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves a recent concern raised internally where tar.exe failed with some exit code that was larger than INT_MAX which got smashed by: https://github.com/microsoft/vcpkg-tool/blob/ee9a2545111704c900b164680b98391f1bf78c59/src/vcpkg/base/system.process.cpp#L1426
vicroms
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a recent concern raised internally where tar.exe failed with some exit code that was larger than INT_MAX which got smashed by:
vcpkg-tool/src/vcpkg/base/system.process.cpp
Line 1426 in ee9a254
Related: #1488
Related: microsoft/vcpkg#40850