-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libiconv port #112
Comments
Hmm, this is unfortunate. Please take whichever path you find most productive; as a general guideline we'd prefer using the original sources and only the linked repository's CMakeLists.txt/sln to make it easier for others to trust the port. |
I agree that using the original build system is preferable, but libiconv uses configure and automake, which I don't think can be used with MSVC, so I was thinking we'd ship the original + a patch that adds cmake files to build libiconv. |
Might be worth looking at the build setup for some of PHP's dependencies on windows: https://github.com/winlibs/ iconv is included. |
@Orvid I've seen that, and considered it. But it makes more sense to me for use to use a CMake based system, so instead of maintaining 4+ solutions, there is just one cmake file, which can build for whichever VS version you need. |
Since #118 is merged, I am going to close this. |
Exclude `libid3tag` and `hss1394` from Linux builds
As part of #34, a libiconv port is needed first. Sadly, the GNU folks decided to remove support for MSVC. As I see it, a patch that adds cmake or vcxproj files for the library are needed. There is an issue on the GNU issues which has a VS10 sln, but there are cmake-ified versions of the latest libiconv, which seem cleaner than using MSVC build files.
The text was updated successfully, but these errors were encountered: