Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libiconv port #112

Closed
ethanhs opened this issue Oct 3, 2016 · 5 comments
Closed

libiconv port #112

ethanhs opened this issue Oct 3, 2016 · 5 comments
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!

Comments

@ethanhs
Copy link
Contributor

ethanhs commented Oct 3, 2016

As part of #34, a libiconv port is needed first. Sadly, the GNU folks decided to remove support for MSVC. As I see it, a patch that adds cmake or vcxproj files for the library are needed. There is an issue on the GNU issues which has a VS10 sln, but there are cmake-ified versions of the latest libiconv, which seem cleaner than using MSVC build files.

@ras0219-msft
Copy link
Contributor

Hmm, this is unfortunate. Please take whichever path you find most productive; as a general guideline we'd prefer using the original sources and only the linked repository's CMakeLists.txt/sln to make it easier for others to trust the port.

@ras0219-msft ras0219-msft added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 3, 2016
@ethanhs
Copy link
Contributor Author

ethanhs commented Oct 3, 2016

as a general guideline we'd prefer using the original sources and only the linked repository's CMakeLists.txt/sln to make it easier for others to trust the port.

I agree that using the original build system is preferable, but libiconv uses configure and automake, which I don't think can be used with MSVC, so I was thinking we'd ship the original + a patch that adds cmake files to build libiconv.

@Orvid
Copy link

Orvid commented Oct 3, 2016

Might be worth looking at the build setup for some of PHP's dependencies on windows: https://github.com/winlibs/ iconv is included.

@ethanhs
Copy link
Contributor Author

ethanhs commented Oct 3, 2016

@Orvid I've seen that, and considered it. But it makes more sense to me for use to use a CMake based system, so instead of maintaining 4+ solutions, there is just one cmake file, which can build for whichever VS version you need.

@ethanhs
Copy link
Contributor Author

ethanhs commented Oct 5, 2016

Since #118 is merged, I am going to close this.

@ethanhs ethanhs closed this as completed Oct 5, 2016
fwcd pushed a commit to fwcd/vcpkg that referenced this issue Feb 6, 2024
Exclude `libid3tag` and `hss1394` from Linux builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

No branches or pull requests

3 participants