Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk missing and broken pkgconfig files #12282

Closed
rukai opened this issue Jul 6, 2020 · 7 comments
Closed

gtk missing and broken pkgconfig files #12282

rukai opened this issue Jul 6, 2020 · 7 comments
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@rukai
Copy link

rukai commented Jul 6, 2020

Describe the bug
The directory lib/pkgconfig is supposed to contain pkgconfig files for gtk, however some of them are missing.
I was instructed they were required here gtk-rs/gtk#1032

Environment

  • OS: Windows

To Reproduce

git clone https://github.com/Microsoft/vcpkg
cd vcpkg
.\bootstrap-vcpkg.bat
vcpkg install gtk:x64-windows

Expected behavior
The command pkg-config --libs gtk+-3.0 should succeed

PS C:\Users\rukai\Projects\vcpkg\installed\x64-windows\lib\pkgconfig> ls


    Directory: C:\Users\rukai\Projects\vcpkg\installed\x64-windows\lib\pkgconfig


Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a----         5/07/2020   3:52 PM            323 epoxy.pc
-a----         5/07/2020   3:47 PM            425 gio-2.0.pc
-a----         5/07/2020   3:47 PM            330 gio-windows-2.0.pc
-a----         5/07/2020   3:47 PM            387 glib-2.0.pc
-a----         5/07/2020   3:47 PM            278 gmodule-2.0.pc
-a----         5/07/2020   3:47 PM            278 gmodule-export-2.0.pc
-a----         5/07/2020   3:47 PM            277 gmodule-no-export-2.0.pc
-a----         5/07/2020   3:47 PM            270 gobject-2.0.pc
-a----         5/07/2020   3:47 PM            232 gthread-2.0.pc
-a----         5/07/2020   3:46 PM            330 libpcre.pc
-a----         5/07/2020   3:46 PM            335 libpcre16.pc
-a----         5/07/2020   3:46 PM            335 libpcre32.pc
-a----         5/07/2020   3:46 PM            275 libpcrecpp.pc
-a----         5/07/2020   3:46 PM            318 libpcreposix.pc


PS C:\Users\rukai\Projects\vcpkg\installed\x64-windows\lib\pkgconfig> pkg-config --libs gtk+-3.0
Package gtk+-3.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `gtk+-3.0.pc'
to the PKG_CONFIG_PATH environment variable
No package 'gtk+-3.0' found
PS C:\Users\rukai\Projects\vcpkg\installed\x64-windows\lib\pkgconfig> pkg-config --libs glib-2.0
-LC:/Users/rukai/Projects/vcpkg/installed/x64-windows/lib -lglib-2.0
PS C:\Users\rukai\Projects\vcpkg\installed\x64-windows\lib\pkgconfig>

problem 2
We also just noticed that the .pc files that do exist are actually broken due to having an empty version.
e.g. glib-2.0.pc:

prefix=${pcfiledir}/../..
exec_prefix=${prefix}
libdir=${prefix}/lib
includedir=${prefix}/include

glib_genmarshal=glib-genmarshal
gobject_query=gobject-query
glib_mkenums=glib-mkenums

Name: GLib
Description: C Utility Library
Version: 
Requires.private: 
Libs: -L${libdir} -lglib-2.0 
Libs.private:       
Cflags: -I${includedir}/glib-2.0 -I${libdir}/glib-2.0/include 
@MVoz
Copy link
Contributor

MVoz commented Jul 6, 2020

env PKG_CONFIG_PATH ?

echo %PKG_CONFIG_PATH%

set PKG_CONFIG_PATH=...

@rukai
Copy link
Author

rukai commented Jul 6, 2020

PS C:\Users\rukai> echo $env:PKG_CONFIG_PATH
C:\Users\rukai\Projects\vcpkg\installed\x64-windows\lib\pkgconfig

@MVoz
Copy link
Contributor

MVoz commented Jul 6, 2020

ls C:\Users\rukai\Projects\vcpkg\installed\x64-windows\lib\pkgconfig\gtk+-3.0.pc
?

everything is clear, there is no configuration file

needs to be edited port file

@rukai
Copy link
Author

rukai commented Jul 6, 2020

We also just noticed that the .pc files that do exist are actually broken due to having an empty version.
e.g. glib-2.0.pc:

prefix=${pcfiledir}/../..
exec_prefix=${prefix}
libdir=${prefix}/lib
includedir=${prefix}/include

glib_genmarshal=glib-genmarshal
gobject_query=gobject-query
glib_mkenums=glib-mkenums

Name: GLib
Description: C Utility Library
Version: 
Requires.private: 
Libs: -L${libdir} -lglib-2.0 
Libs.private:       
Cflags: -I${includedir}/glib-2.0 -I${libdir}/glib-2.0/include 

@rukai rukai changed the title gtk missing pkgconfig files gtk missing and broken pkgconfig files Jul 6, 2020
@PhoebeHui PhoebeHui added the category:port-bug The issue is with a library, which is something the port should already support label Jul 7, 2020
@PhoebeHui
Copy link
Contributor

Thanks for reporting this issue! I will take a look.

@PhoebeHui
Copy link
Contributor

@rukai, I have summited PR #12326 to fix this issue, would you like to test if it works for you?

ravgeetdhillon pushed a commit to ravgeetdhillon/gtk-web that referenced this issue Sep 6, 2020
@JackBoosY
Copy link
Contributor

Duplicated to #7641.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@rukai @MVoz @PhoebeHui @JackBoosY and others