Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCPkg does not support the v143 MSVC toolset #18987

Closed
Ryan-rsm-McKenzie opened this issue Jul 17, 2021 · 3 comments · Fixed by microsoft/vcpkg-tool#124 or #19159
Closed

VCPkg does not support the v143 MSVC toolset #18987

Ryan-rsm-McKenzie opened this issue Jul 17, 2021 · 3 comments · Fixed by microsoft/vcpkg-tool#124 or #19159
Assignees
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed

Comments

@Ryan-rsm-McKenzie
Copy link
Contributor

Describe the bug
VCPkg does not support the v143 MSVC toolset. It seems to stem from a missing entry in this hard-coded list:
https://github.com/microsoft/vcpkg-tool/blob/3be6b75f6972aa72ca34afce39168094432ea300/src/vcpkg/visualstudio.cpp#L15-L18
And subsequently a missing case here:
https://github.com/microsoft/vcpkg-tool/blob/main/src/vcpkg/visualstudio.cpp#L252-L266

Environment

  • OS: Windows
  • Compiler: VS 2022 17.0 Preview 2.0

To Reproduce
Given some valid cmake project:

  1. cmake -B build -S . -G "Visual Studio 17 2022" -T v143 -DCMAKE_TOOLCHAIN_FILE="path/to/vcpkg/scripts/buildsystems/vcpkg.cmake"
  2. See error
-- Running vcpkg install
No suitable Visual Studio instances were found
-- Running vcpkg install - failed
CMake Error at E:/Repos/vcpkg/scripts/buildsystems/vcpkg.cmake:837 (message):
  vcpkg install failed.  See logs for more information:
  E:\Repos\bsa\build\vcpkg-manifest-install.log
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.21/Modules/CMakeDetermineSystem.cmake:124 (include)
  CMakeLists.txt:3 (project)

Expected behavior
I would expect vcpkg to recognize the v143 toolset.

Failure logs
vcpkg-manifest-install.log

No suitable Visual Studio instances were found
@SmartPolarBear
Copy link

Same issue.

@PhoebeHui PhoebeHui added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Jul 19, 2021
@PhoebeHui PhoebeHui self-assigned this Jul 19, 2021
@PhoebeHui
Copy link
Contributor

@Ryan-rsm-McKenzie, thanks for bringing this up!

This is not supported yet, we would work for it recently.

@BillyONeal
Copy link
Member

Reopening until we do a binary release to pick up the fix.

@BillyONeal BillyONeal added the requires:tool-release An issue that has been fixed in the microsoft/vcpkg-tool repo and is waiting for a release thereof label Jul 22, 2021
@BillyONeal BillyONeal removed the requires:tool-release An issue that has been fixed in the microsoft/vcpkg-tool repo and is waiting for a release thereof label Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed
Projects
None yet
4 participants