-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg_cmake_configure/vcpkg_configure_cmake] Support VS2022 17.0 #19088
Conversation
doesn't this also require a change to |
The pistache issue would be fixed by #19206 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for vcpkg-cmake but no changes to version or port version.
-- Version: 2021-07-30
-- Old SHA: c6df7e0faeda9e783175746c7c440c9bc2bdb111
-- New SHA: 0542cefb59997978bc64b94968d3938c2f6665ec
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 63aa65e65b9d2c08772ea15d25fb8fdb0d32e557 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/v-/vcpkg-cmake.json b/versions/v-/vcpkg-cmake.json
index 26659d1..276f18a 100644
--- a/versions/v-/vcpkg-cmake.json
+++ b/versions/v-/vcpkg-cmake.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "0542cefb59997978bc64b94968d3938c2f6665ec",
+ "git-tree": "6b7d32d2b71c5165213ec0f4cd5b691da00d11b7",
"version-date": "2021-07-30",
"port-version": 1
},
qt5-tools[core]:x86-windows failed in CI testing, it looks a baseline issue.
@Neumann-A, do you know more about the failures? I tried to repro this issue locally, however, both qt5-tools and qt5-declarative don't have tools/qt5/bin/qml/QtQuick/XmlListModel/qmlxmllistmodelplugin.dll. |
Thanks for the fix! |
Related to #18987
Support VS2022, change the order to select the cmake generator.