Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openal-soft] Incorrect prefix in .pc file #19316

Closed
s0600204 opened this issue Aug 3, 2021 · 1 comment · Fixed by #19318
Closed

[openal-soft] Incorrect prefix in .pc file #19316

s0600204 opened this issue Aug 3, 2021 · 1 comment · Fixed by #19318
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@s0600204
Copy link

s0600204 commented Aug 3, 2021

Current problem
The prefix line written to the openal.pc file is incorrect. It currently looks something like:

prefix=D:/a/0ad/0ad/libraries/win32-build/vcpkg/vc/packages/openal-soft_x86-windows

(Exact text will differ depending on triplet, and the location of where vcpkg is building things.)

Proposed solution
Based on other .pc files exported by vcpkg, it should read:

prefix=${pcfiledir}/../..

Describe alternatives you've considered
I'm currently employing a workaround (search-replace of text) in a project that relies on .pc files. Would like to remove that workaround if possible.

@NancyLi1013 NancyLi1013 added the category:port-bug The issue is with a library, which is something the port should already support label Aug 3, 2021
@NancyLi1013
Copy link
Contributor

Hi @s0600204

Thanks for posting this issue.

Needs to add vcpkg_fixup_pkgconfig() to fix the paths in .pc files. I will submit a PR to fix this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants