Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nuspell] build failure on master. #24533

Closed
talregev opened this issue May 4, 2022 · 4 comments · Fixed by #24542
Closed

[nuspell] build failure on master. #24533

talregev opened this issue May 4, 2022 · 4 comments · Fixed by #24542
Assignees
@JackBoosY
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@talregev
Copy link
Contributor

talregev commented May 4, 2022 •
edited
Loading

nuspell build failure on master.
Please fix it.
@Neumann-A
Copy link
Contributor

CI runs fine so what is the error?

@talregev
Copy link
Contributor Author

talregev commented May 4, 2022

From master:
https://dev.azure.com/vcpkg/public/_build/results?buildId=71602&view=results
https://dev.azure.com/vcpkg/public/_build/results?buildId=71602&view=logs&j=878666d5-db33-5b27-9e7d-b0c7ee352005&t=d914c609-a9aa-5880-221f-cbd46db9069e

For example it fail on nuspell:x86-windows also for x64. test locally also fail.

@Neumann-A
Copy link
Contributor

Yeah baseline issue. No reason to open up an extremely short unhelpful issue without also telling the error in detail.
Since you have been around long enough to know this, you earned my thumbs down for your main comment :P

Main CI is rarely completely clean, so having only 1-2 ports fail is already quite good. Having a title like: "[all ports] build failure on master" seems to indicate nothing builds and everything fails which is not the case and wasn't your intention. Please be more concise with your descriptions.

@talregev
Copy link
Contributor Author

talregev commented May 4, 2022 •
edited
Loading

Sorry, You are right. I was over dramatic. Should I change the title and you will remove the thumbs down?

@talregev talregev changed the title [all ports] build failure on master. (why?) [nuspell] build failure on master. May 4, 2022
@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label May 5, 2022
@LilyWangLL LilyWangLL mentioned this issue May 5, 2022
Merged
@LilyWangLL LilyWangLL assigned JackBoosY and unassigned LilyWangLL May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vcpkg baseline][nuspell] Add and fix feature tools JackBoosY/vcpkg
4 participants
@talregev @Neumann-A @JackBoosY @LilyWangLL