Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][nuspell] Add and fix feature tools #24542

Merged

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented May 5, 2022

Add feature tools and fix its dependency getopt since getopt_long isn't provided in Win32 api.

Related: #22676
Fixes #24533

Already tested this feature on x86-windows.

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels May 5, 2022
@JackBoosY JackBoosY requested a review from LilyWangLL May 5, 2022 06:02
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label May 5, 2022
@BillyONeal BillyONeal merged commit 8e5e74f into microsoft:master May 5, 2022
@BillyONeal
Copy link
Member

Thanks for the baseline fix!

@JackBoosY JackBoosY deleted the dev/jack/fix-baseline-20220505 branch May 6, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nuspell] build failure on master.
3 participants