Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg-tool] x-add-version --all crashes if there are uncommited ports in the tree. #24669

Closed
Neumann-A opened this issue May 12, 2022 · 1 comment · Fixed by microsoft/vcpkg-tool#539
Assignees
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)

Comments

@Neumann-A
Copy link
Contributor

Neumann-A commented May 12, 2022

neumann@heineken MINGW64 /e/vcpkg_folders/master (fortran_flang_ifort_combined)
$ ./vcpkg.exe x-add-version --all --overwrite-version
warning: can't obtain SHA for port vcpkg-tool-sed
-- Did you remember to commit your changes?
***No files were updated***
internal error: D:\a\_work\1\s\src\vcpkg\commands.add-version.cpp(556): vcpkg has crashed; no additional details are available.
Please open an issue at https://github.com/microsoft/vcpkg/issues/new?template=other-type-of-bug-report.md&labels=category:vcpkg-bug with detailed steps to reproduce the problem.

didn't happen with the previous versions.
So either microsoft/vcpkg-tool#489 or microsoft/vcpkg-tool#526 broke it.

cc @vicroms

@LilyWangLL LilyWangLL added the category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) label May 12, 2022
@LilyWangLL
Copy link
Contributor

I have reproduced this issue locally, if I create a new port, but I uncommit this port and use command ./vcpkg.exe x-add-version --all --overwrite-version, vcpkg will crash and report internal error.
image
cc @BillyONeal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants