Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crashpad] Build failure #25066

Closed
njakob opened this issue Jun 4, 2022 · 0 comments · Fixed by #25106
Closed

[crashpad] Build failure #25066

njakob opened this issue Jun 4, 2022 · 0 comments · Fixed by #25106
Assignees
@LilyWangLL
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@njakob
Copy link
Contributor

njakob commented Jun 4, 2022 •
edited
Loading

Host Environment

  • OS: Windows (windows-2019 in GitHub actions)
  • Compiler: MSVC 19.29.30145.0

To Reproduce
The following repository contains a minimal example to reproduce the problem. It contains a successful build (master branch) of the crashpad port version 2022.04.12 and a failed build under 2022.05.10 (update branch).

Failure logs

Error: D:\a\crashpad-error\crashpad-error\build\windows-release\vcpkg_installed\x64-windows\include\crashpad\base/files/file_path.h(110): fatal error C1083: Cannot open include file: 'build/build_config.h': No such file or directory

Additional context
As per the example repository, the crashpad port does produce build errors when consumed since 2022.05.10.

After looking at recent changes, it is mostly related to the changes made in #24066 and one possible pointer could be #24066 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[crashpad] Fix can't find build/build_config.h LilyWangLL/vcpkg
2 participants
@njakob @LilyWangLL