[skia,crashpad,zeroc-ice,vcpkg-tool-gn] New vcpkg-tool-gn and update of several ports #24066

bold84 · 2022-04-10T08:42:37Z

Describe the pull request

What does your PR fix?

Updates Skia to newer version
Which triplets are supported/not supported? Have you updated the CI baseline?

unchanged
Does your PR follow the maintainer guide?

Yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/skia/vcpkg.json

Valid values for the license field can be found in the documentation

ports/skia/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for skia but no changes to version or port version.
-- Version: 2022-04-10#8
-- Old SHA: f81f5433b1504578917d63c5f339e80af0853d7f
-- New SHA: 3ec42896de4132b03838730b412301a0239cfe02
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/skia/vcpkg.json

Valid values for the license field can be found in the documentation

JonLiu1993 · 2022-04-11T08:21:48Z

@bold84 , If this pr is ready for review please let me know, thanks!

bold84 · 2022-04-14T12:28:00Z

This depends on #24142

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5d66a98f64188bbd806b8e62e66c097d90eb3224 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 11a05e6..84e8a1b 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6517,7 +6517,7 @@
       "port-version": 0
     },
     "skia": {
-      "baseline": "2022-04-10",
+      "baseline": "2022-04-15",
       "port-version": 9
     },
     "skyr-url": {
diff --git a/versions/s-/skia.json b/versions/s-/skia.json
index 79d988c..944f71f 100644
--- a/versions/s-/skia.json
+++ b/versions/s-/skia.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "83d939524e7184577f3f9154f5e0f4ae3b92c2b4",
+      "version-date": "2022-04-15",
+      "port-version": 9
+    },
     {
       "git-tree": "68e77104f54fa164b2890ae0eb860315b8cf318c",
       "version-date": "2022-04-10",

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/skia/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 5d66a98f64188bbd806b8e62e66c097d90eb3224 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index ef1001d..d0cc13e 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6517,7 +6517,7 @@
       "port-version": 0
     },
     "skia": {
-      "baseline": "2022-04-10",
+      "baseline": "2022-04-15",
       "port-version": 9
     },
     "skyr-url": {
diff --git a/versions/s-/skia.json b/versions/s-/skia.json
index 79d988c..944f71f 100644
--- a/versions/s-/skia.json
+++ b/versions/s-/skia.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "83d939524e7184577f3f9154f5e0f4ae3b92c2b4",
+      "version-date": "2022-04-15",
+      "port-version": 9
+    },
     {
       "git-tree": "68e77104f54fa164b2890ae0eb860315b8cf318c",
       "version-date": "2022-04-10",

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/crashpad/vcpkg.json
ports/skia/vcpkg.json

Valid values for the license field can be found in the documentation

bold84 · 2022-04-15T20:04:27Z

This is weird... I don't have these errors on two Windows machines with Windows 11 and VS 2022.

What's even weirder is that even the zeroc-ice port (x64-windows-static) suddenly fails on your windows servers, although nothing was changed.

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/crashpad/vcpkg.json
ports/skia/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/crashpad/vcpkg.json
ports/skia/vcpkg.json

Valid values for the license field can be found in the documentation

dg0yt · 2022-04-16T06:28:53Z

What's even weirder is that even the zeroc-ice port (x64-windows-static) suddenly fails on your windows servers, although nothing was changed.

This is a baseline regression, also failing in the daily full builds: https://dev.azure.com/vcpkg/public/_build/results?buildId=70644&view=results

bold84 · 2022-04-16T06:53:44Z

@dg0yt
Thank you for letting me know. I figured that out by now 😊.
I was able to reproduce the issues and make everything build successfully, despite the regression.

I think that this was a good opportunity to fix a potential problem with the zeroc-ice port.

I will push the changes soon (still in bed).

dg0yt · 2022-04-16T08:00:02Z

@bold84 There is already other work on zero-ice: #24169

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/crashpad/vcpkg.json
ports/skia/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/crashpad/vcpkg.json
ports/skia/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/crashpad/vcpkg.json
ports/skia/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/crashpad/vcpkg.json
ports/skia/vcpkg.json
ports/v8/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/crashpad/vcpkg.json
ports/skia/vcpkg.json
ports/v8/vcpkg.json

Valid values for the license field can be found in the documentation

…uilding skia[dawn] feature on Linux.

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

strega-nil-ms · 2022-04-22T16:50:04Z

rebased and fixed spaces; gonna wait for green one last time :)

ports/crashpad/vcpkg.json

BillyONeal · 2022-04-25T22:39:22Z

rebased and fixed spaces; gonna wait for green one last time :)

I didn't review; I just merged green build based on this :)

njakob · 2022-06-03T12:08:43Z

ports/crashpad/portfile.cmake

@@ -119,6 +122,9 @@ file(REMOVE_RECURSE
 configure_file("${CMAKE_CURRENT_LIST_DIR}/crashpadConfig.cmake.in"
        "${CURRENT_PACKAGES_DIR}/share/${PORT}/crashpadConfig.cmake" @ONLY)

+file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/include/${PORT}/build")


I'm currently running into the following error while using the latest version of crashpad (2022-04-16) on Windows. Can this line be responsible for the missing files and is this an intended behavior?

Error: %REDACTED%\build\windows-release\vcpkg_installed\x64-windows\include\crashpad\base/files/file_path.h(110): fatal error C1083: Cannot open include file: 'build/build_config.h': No such file or directory

I'm not sure if it's related to #24510 or if it deserves its own issue?

CC @bold84

I created a new issue regarding this problem #25066

bold84 changed the title ~~Update skia~~ [skia] Update skia Apr 10, 2022

github-actions bot approved these changes Apr 10, 2022

View reviewed changes

bold84 marked this pull request as draft April 10, 2022 12:50

JonLiu1993 self-assigned this Apr 11, 2022

JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Apr 11, 2022

JonLiu1993 reviewed Apr 11, 2022

View reviewed changes

ports/skia/portfile.cmake Outdated Show resolved Hide resolved

JonLiu1993 reviewed Apr 11, 2022

View reviewed changes

ports/skia/portfile.cmake Outdated Show resolved Hide resolved

github-actions bot requested changes Apr 11, 2022

View reviewed changes

JonLiu1993 added the depends:different-pr This PR or Issue depends on a PR which has been filed label Apr 15, 2022

bold84 mentioned this pull request Apr 15, 2022

[gn] Update to current version #24142

Closed

bold84 changed the title ~~[skia] Update skia~~ [gn,skia] Update Apr 15, 2022

github-actions bot requested changes Apr 15, 2022

View reviewed changes

github-actions bot approved these changes Apr 15, 2022

View reviewed changes

bold84 changed the title ~~[gn,skia] Update~~ [gn,skia,crashpad] Update Apr 15, 2022

github-actions bot approved these changes Apr 15, 2022

View reviewed changes

github-actions bot approved these changes Apr 16, 2022

View reviewed changes

bold84 changed the title ~~[gn,skia,crashpad] Update~~ [gn,skia,crashpad,zeroc-ice] Update Apr 16, 2022

bold84 mentioned this pull request Apr 16, 2022

[zeroc-ice] correct windows-static and linux #24169

Merged

github-actions bot approved these changes Apr 16, 2022

View reviewed changes

bold84 marked this pull request as ready for review April 16, 2022 16:00

github-actions bot approved these changes Apr 16, 2022

View reviewed changes

bold84 and others added 15 commits April 22, 2022 09:33

updated version

f5c164c

Increased port version for zeroc-ice and skia and added warning for b…

8fee76d

…uilding skia[dawn] feature on Linux.

don't install dawn when not built

9a5c30d

Update ports/chromium-base/vcpkg.json

f3ec20b

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

Update ports/crashpad/portfile.cmake

1c28cf6

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

Update ports/crashpad/vcpkg.json

7e98b34

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

fixed git-tree issue

16026fc

Update ports/skia/portfile.cmake

b97dd23

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

Fixed versioning / git-tree

06426cf

Update ports/skia/portfile.cmake

9286158

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

Update ports/skia/vcpkg.json

f9d5fed

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

Update ports/crashpad/vcpkg.json

5d3cbb3

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

updated ci.ci.baseline.txt

add7e30

fixed versions

c06050b

versions + space changes

c232b6e

strega-nil-ms force-pushed the update_skia branch from 873b7d4 to c232b6e Compare April 22, 2022 16:49

github-actions bot approved these changes Apr 22, 2022

View reviewed changes

Thomas1664 reviewed Apr 23, 2022

View reviewed changes

ports/crashpad/vcpkg.json Show resolved Hide resolved

Thomas1664 approved these changes Apr 23, 2022

View reviewed changes

JackBoosY removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Apr 24, 2022

BillyONeal merged commit ce910bb into microsoft:master Apr 25, 2022

bold84 deleted the update_skia branch April 29, 2022 01:34

hugoam mentioned this pull request May 2, 2022

[v8] Build failure in x64-windows (likely broken by PR #24066) #24510

Closed

njakob reviewed Jun 3, 2022

View reviewed changes

njakob mentioned this pull request Jun 4, 2022

[crashpad] Build failure #25066

Closed

LilyWangLL mentioned this pull request Jun 7, 2022

[crashpad] Fix can't find build/build_config.h #25106

Merged

JonLiu1993 mentioned this pull request Aug 18, 2022

[Skia] Bump Version #17758

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[skia,crashpad,zeroc-ice,vcpkg-tool-gn] New vcpkg-tool-gn and update of several ports #24066

[skia,crashpad,zeroc-ice,vcpkg-tool-gn] New vcpkg-tool-gn and update of several ports #24066

bold84 commented Apr 10, 2022

github-actions bot left a comment

github-actions bot left a comment

JonLiu1993 commented Apr 11, 2022

bold84 commented Apr 14, 2022

github-actions bot left a comment

github-actions bot left a comment

bold84 commented Apr 15, 2022

github-actions bot left a comment

github-actions bot left a comment

dg0yt commented Apr 16, 2022

bold84 commented Apr 16, 2022 •

edited

Loading

dg0yt commented Apr 16, 2022

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

strega-nil-ms commented Apr 22, 2022

BillyONeal commented Apr 25, 2022

njakob Jun 3, 2022

njakob Jun 4, 2022

[skia,crashpad,zeroc-ice,vcpkg-tool-gn] New vcpkg-tool-gn and update of several ports #24066

[skia,crashpad,zeroc-ice,vcpkg-tool-gn] New vcpkg-tool-gn and update of several ports #24066

Conversation

bold84 commented Apr 10, 2022

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

JonLiu1993 commented Apr 11, 2022

bold84 commented Apr 14, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

bold84 commented Apr 15, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

dg0yt commented Apr 16, 2022

bold84 commented Apr 16, 2022 • edited Loading

dg0yt commented Apr 16, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

strega-nil-ms commented Apr 22, 2022

BillyONeal commented Apr 25, 2022

njakob Jun 3, 2022

Choose a reason for hiding this comment

njakob Jun 4, 2022

Choose a reason for hiding this comment

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

bold84 commented Apr 16, 2022 •

edited

Loading