-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skia,crashpad,zeroc-ice,vcpkg-tool-gn] New vcpkg-tool-gn and update of several ports #24066
Merged
Merged
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
2f888ee
newer Skia version
bold84 57404fe
Update ports/skia/portfile.cmake
bold84 0dbd64e
use absolute python 3 path
bold84 6a92c04
fix issue with gn file
bold84 e379852
Update GN for Windows
bold84 8bdd0b6
updated gn for mac and linux (amd64 / arm64)
bold84 1d9cd3c
removed empty line
bold84 6027b27
Remove patch files
bold84 a57b244
changes from vejmartin
bold84 eb863cb
make skia build x64-windows
bold84 2609ae6
update version
bold84 c3bf098
update version
bold84 0d2f053
enable linux
bold84 787ba23
update crashpad
bold84 725b550
make crashpad build on windows
bold84 8d24d7c
formatted crashpad/vcpkg.json
bold84 eaeff3f
update version
bold84 ece6a82
remove portfile
bold84 0f4a218
add file again
bold84 433fb1e
Looks like the CMake's rules for finding libraries have changed betwe…
bold84 c52915b
updated version
bold84 a677be0
Fix static crt issue
bold84 d203d93
Fix Skia for arm64-windows
bold84 27c2e39
disable linux again
bold84 5723f6e
disable linux
bold84 c73947e
update version
bold84 e719f2d
set v8 to fail on linux
bold84 4d53207
skia doesn't support x86 builds with local MSVC installations
bold84 c7cdf1c
review change requests
bold84 4c73298
review changes
bold84 182aa46
added vcpkg-tool-gn
bold84 780f47b
Updated license fields and reverted changes to ci.baseline.txt
bold84 512c32f
enable linux again :-)
bold84 3f4e56f
Enabled additional backends
bold84 1f8b303
Fixes after merge conflicts
bold84 f5c164c
updated version
bold84 8fee76d
Increased port version for zeroc-ice and skia and added warning for b…
bold84 9a5c30d
don't install dawn when not built
bold84 f3ec20b
Update ports/chromium-base/vcpkg.json
bold84 1c28cf6
Update ports/crashpad/portfile.cmake
bold84 7e98b34
Update ports/crashpad/vcpkg.json
bold84 16026fc
fixed git-tree issue
bold84 b97dd23
Update ports/skia/portfile.cmake
bold84 06426cf
Fixed versioning / git-tree
bold84 9286158
Update ports/skia/portfile.cmake
bold84 f9d5fed
Update ports/skia/vcpkg.json
bold84 5d3cbb3
Update ports/crashpad/vcpkg.json
bold84 add7e30
updated ci.ci.baseline.txt
bold84 c06050b
fixed versions
bold84 c232b6e
versions + space changes
strega-nil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,15 @@ | ||
{ | ||
"name": "chromium-base", | ||
"version-string": "86.0.4199.1", | ||
"port-version": 3, | ||
"version": "86.0.4199.1", | ||
"port-version": 4, | ||
"description": "Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.", | ||
"homepage": "https://chromium.googlesource.com/chromium/src", | ||
"supports": "x64 & (osx | windows | linux) & !uwp" | ||
"license": "BSD-3-Clause", | ||
"supports": "x64 & (osx | windows | linux) & !uwp", | ||
"dependencies": [ | ||
{ | ||
"name": "vcpkg-tool-gn", | ||
"host": true | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,18 @@ | ||
{ | ||
"name": "crashpad", | ||
"version-date": "2020-03-18", | ||
"port-version": 2, | ||
"version-date": "2022-04-16", | ||
bold84 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"description": [ | ||
"Crashpad is a crash-reporting system.", | ||
"Crashpad is a library for capturing, storing and transmitting postmortem crash reports from a client to an upstream collection server. Crashpad aims to make it possible for clients to capture process state at the time of crash with the best possible fidelity and coverage, with the minimum of fuss." | ||
], | ||
"homepage": "https://chromium.googlesource.com/crashpad/crashpad/+/master/README.md", | ||
"supports": "x64 & (osx | windows)", | ||
"license": "Apache-2.0", | ||
"supports": "osx | windows", | ||
"dependencies": [ | ||
{ | ||
"name": "vcpkg-tool-gn", | ||
"host": true | ||
}, | ||
"zlib" | ||
] | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
diff --git a/src/dawn_native/BUILD.gn b/src/dawn_native/BUILD.gn | ||
index f73bfe24..e37792a0 100644 | ||
--- a/src/dawn_native/BUILD.gn | ||
+++ b/src/dawn_native/BUILD.gn | ||
@@ -145,7 +145,7 @@ source_set("dawn_native_sources") { | ||
":dawn_native_headers", | ||
":dawn_native_utils_gen", | ||
"${dawn_root}/src/common", | ||
- "${dawn_root}/third_party/gn/spirv_cross:spirv_cross", | ||
+ "//third_party/spirv-cross:spirv_cross", | ||
"${dawn_spirv_tools_dir}:spvtools_opt", | ||
"${dawn_spirv_tools_dir}:spvtools_val", | ||
"${dawn_tint_dir}/src:libtint", |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import("../third_party.gni") | ||
|
||
system("fontconfig") { | ||
include_dirs = @_INCLUDES@ | ||
if(is_debug) { | ||
libs = @_LIBS_DBG@ | ||
} else { | ||
libs = @_LIBS_REL@ | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm currently running into the following error while using the latest version of crashpad (
2022-04-16
) on Windows. Can this line be responsible for the missing files and is this an intended behavior?I'm not sure if it's related to #24510 or if it deserves its own issue?
CC @bold84
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a new issue regarding this problem #25066