Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skia,crashpad,zeroc-ice,vcpkg-tool-gn] New vcpkg-tool-gn and update of several ports #24066

Merged
merged 50 commits into from
Apr 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
2f888ee
newer Skia version
bold84 Apr 10, 2022
57404fe
Update ports/skia/portfile.cmake
bold84 Apr 11, 2022
0dbd64e
use absolute python 3 path
bold84 Apr 13, 2022
6a92c04
fix issue with gn file
bold84 Apr 13, 2022
e379852
Update GN for Windows
bold84 Apr 14, 2022
8bdd0b6
updated gn for mac and linux (amd64 / arm64)
bold84 Apr 14, 2022
1d9cd3c
removed empty line
bold84 Apr 14, 2022
6027b27
Remove patch files
bold84 Apr 14, 2022
a57b244
changes from vejmartin
bold84 Apr 15, 2022
eb863cb
make skia build x64-windows
bold84 Apr 15, 2022
2609ae6
update version
bold84 Apr 15, 2022
c3bf098
update version
bold84 Apr 15, 2022
0d2f053
enable linux
bold84 Apr 15, 2022
787ba23
update crashpad
bold84 Apr 15, 2022
725b550
make crashpad build on windows
bold84 Apr 15, 2022
8d24d7c
formatted crashpad/vcpkg.json
bold84 Apr 15, 2022
eaeff3f
update version
bold84 Apr 15, 2022
ece6a82
remove portfile
bold84 Apr 15, 2022
0f4a218
add file again
bold84 Apr 15, 2022
433fb1e
Looks like the CMake's rules for finding libraries have changed betwe…
bold84 Apr 15, 2022
c52915b
updated version
bold84 Apr 15, 2022
a677be0
Fix static crt issue
bold84 Apr 16, 2022
d203d93
Fix Skia for arm64-windows
bold84 Apr 16, 2022
27c2e39
disable linux again
bold84 Apr 16, 2022
5723f6e
disable linux
bold84 Apr 16, 2022
c73947e
update version
bold84 Apr 16, 2022
e719f2d
set v8 to fail on linux
bold84 Apr 16, 2022
4d53207
skia doesn't support x86 builds with local MSVC installations
bold84 Apr 17, 2022
c7cdf1c
review change requests
bold84 Apr 17, 2022
4c73298
review changes
bold84 Apr 17, 2022
182aa46
added vcpkg-tool-gn
bold84 Apr 17, 2022
780f47b
Updated license fields and reverted changes to ci.baseline.txt
bold84 Apr 17, 2022
512c32f
enable linux again :-)
bold84 Apr 17, 2022
3f4e56f
Enabled additional backends
bold84 Apr 17, 2022
1f8b303
Fixes after merge conflicts
bold84 Apr 18, 2022
f5c164c
updated version
bold84 Apr 18, 2022
8fee76d
Increased port version for zeroc-ice and skia and added warning for b…
bold84 Apr 18, 2022
9a5c30d
don't install dawn when not built
bold84 Apr 19, 2022
f3ec20b
Update ports/chromium-base/vcpkg.json
bold84 Apr 20, 2022
1c28cf6
Update ports/crashpad/portfile.cmake
bold84 Apr 20, 2022
7e98b34
Update ports/crashpad/vcpkg.json
bold84 Apr 20, 2022
16026fc
fixed git-tree issue
bold84 Apr 20, 2022
b97dd23
Update ports/skia/portfile.cmake
bold84 Apr 20, 2022
06426cf
Fixed versioning / git-tree
bold84 Apr 20, 2022
9286158
Update ports/skia/portfile.cmake
bold84 Apr 20, 2022
f9d5fed
Update ports/skia/vcpkg.json
bold84 Apr 20, 2022
5d3cbb3
Update ports/crashpad/vcpkg.json
bold84 Apr 20, 2022
add7e30
updated ci.ci.baseline.txt
bold84 Apr 20, 2022
c06050b
fixed versions
bold84 Apr 20, 2022
c232b6e
versions + space changes
strega-nil Apr 22, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions ports/chromium-base/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,15 @@
{
"name": "chromium-base",
"version-string": "86.0.4199.1",
"port-version": 3,
"version": "86.0.4199.1",
"port-version": 4,
"description": "Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.",
"homepage": "https://chromium.googlesource.com/chromium/src",
"supports": "x64 & (osx | windows | linux) & !uwp"
"license": "BSD-3-Clause",
"supports": "x64 & (osx | windows | linux) & !uwp",
"dependencies": [
{
"name": "vcpkg-tool-gn",
"host": true
}
]
}
10 changes: 8 additions & 2 deletions ports/crashpad/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,12 @@ vcpkg_check_linkage(ONLY_STATIC_LIBRARY)
vcpkg_from_git(
OUT_SOURCE_PATH SOURCE_PATH
URL https://chromium.googlesource.com/crashpad/crashpad
REF 9a31d3f8e9815774026a753a1ff6155347cd549f
REF 68aba08c48bb428b7b159b3371163f86e8d5a126
)

vcpkg_find_acquire_program(PYTHON3)
vcpkg_replace_string("${SOURCE_PATH}/.gn" "script_executable = \"python3\"" "script_executable = \"${PYTHON3}\"")

function(checkout_in_path PATH URL REF)
if(EXISTS "${PATH}")
return()
Expand All @@ -24,7 +27,7 @@ endfunction()
checkout_in_path(
"${SOURCE_PATH}/third_party/mini_chromium/mini_chromium"
"https://chromium.googlesource.com/chromium/mini_chromium"
"c426ff98e1d9e9d59777fe8b883a5c0ceeca9ca3"
"5654edb4225bcad13901155c819febb5748e502b"
)

function(replace_gn_dependency INPUT_FILE OUTPUT_FILE LIBRARY_NAMES)
Expand Down Expand Up @@ -119,6 +122,9 @@ file(REMOVE_RECURSE
configure_file("${CMAKE_CURRENT_LIST_DIR}/crashpadConfig.cmake.in"
"${CURRENT_PACKAGES_DIR}/share/${PORT}/crashpadConfig.cmake" @ONLY)

file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/include/${PORT}/build")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently running into the following error while using the latest version of crashpad (2022-04-16) on Windows. Can this line be responsible for the missing files and is this an intended behavior?

Error: %REDACTED%\build\windows-release\vcpkg_installed\x64-windows\include\crashpad\base/files/file_path.h(110): fatal error C1083: Cannot open include file: 'build/build_config.h': No such file or directory

I'm not sure if it's related to #24510 or if it deserves its own issue?

CC @bold84

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a new issue regarding this problem #25066

file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/include/${PORT}/util/mach/__pycache__")

vcpkg_copy_pdbs()
file(INSTALL "${SOURCE_PATH}/LICENSE"
DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}"
Expand Down
10 changes: 7 additions & 3 deletions ports/crashpad/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
{
"name": "crashpad",
"version-date": "2020-03-18",
"port-version": 2,
"version-date": "2022-04-16",
bold84 marked this conversation as resolved.
Show resolved Hide resolved
"description": [
"Crashpad is a crash-reporting system.",
"Crashpad is a library for capturing, storing and transmitting postmortem crash reports from a client to an upstream collection server. Crashpad aims to make it possible for clients to capture process state at the time of crash with the best possible fidelity and coverage, with the minimum of fuss."
],
"homepage": "https://chromium.googlesource.com/crashpad/crashpad/+/master/README.md",
"supports": "x64 & (osx | windows)",
"license": "Apache-2.0",
"supports": "osx | windows",
"dependencies": [
{
"name": "vcpkg-tool-gn",
"host": true
},
"zlib"
]
}
12 changes: 0 additions & 12 deletions ports/skia/add-missing-tuple.patch

This file was deleted.

13 changes: 13 additions & 0 deletions ports/skia/dawn_use_vcpkg_spirv.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/src/dawn_native/BUILD.gn b/src/dawn_native/BUILD.gn
index f73bfe24..e37792a0 100644
--- a/src/dawn_native/BUILD.gn
+++ b/src/dawn_native/BUILD.gn
@@ -145,7 +145,7 @@ source_set("dawn_native_sources") {
":dawn_native_headers",
":dawn_native_utils_gen",
"${dawn_root}/src/common",
- "${dawn_root}/third_party/gn/spirv_cross:spirv_cross",
+ "//third_party/spirv-cross:spirv_cross",
"${dawn_spirv_tools_dir}:spvtools_opt",
"${dawn_spirv_tools_dir}:spvtools_val",
"${dawn_tint_dir}/src:libtint",
10 changes: 10 additions & 0 deletions ports/skia/fontconfig.gn
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import("../third_party.gni")

system("fontconfig") {
include_dirs = @_INCLUDES@
if(is_debug) {
libs = @_LIBS_DBG@
} else {
libs = @_LIBS_REL@
}
}
Loading