VCPKG_TRACE_FIND_PACKAGE produces logs although CMAKE_DISABLE_FIND_PACKAGE_ is set

[Thomas1664]

Repro

Using port sdl2:

• Set -DCMAKE_DISABLE_FIND_PACKAGE_Git=ON and -DVCPKG_TRACE_FIND_PACKAGE=ON in OPTIONS
• Notice that the configure logs still contain find_package(Git )

Expected behaviour

Don't see find_package(Git ) in the logs.
It would make it easier to see if finding a certain package is actually disabled or not - especially if we would add a post build check for optional calls to find_package.

/cc: @dg0yt Related: #27982

[dg0yt]

What is really needed is solving #18631. Ping @ras0219-msft for finishing #18961.

[Thomas1664]

What is really needed is solving #18631. Ping @ras0219-msft for finishing #18961.

Is there something missing in this PR? It seems like #18961 can be merged if the conflicts are resolved?

[dg0yt]

There is also #27950 which could be extend to log (disabled by CMAKE_DISABLE_FIND_PACKAGE_<Pkg>=1).

@LilyWangLL There is no real bug here IMO. VCPKG_TRACE_FIND_PACKAGE logs something which does take place: a call to find_package(<Pkg>).

[Thomas1664]

@LilyWangLL There is no real bug here IMO. VCPKG_TRACE_FIND_PACKAGE logs something which does take place: a call to find_package(<Pkg>).

Technically, you are right but IMO there is no reason to log calls to find_package if CMAKE_DISABLE_FIND_PACKAGE_ is set. Furthermore, there won't be a call to find_package if #18961 gets merged so this will indeed be a bug.

[LilyWangLL]

@LilyWangLL There is no real bug here IMO. VCPKG_TRACE_FIND_PACKAGE logs something which does take place: a call to find_package(<Pkg>).

Technically, you are right but IMO there is no reason to log calls to find_package if CMAKE_DISABLE_FIND_PACKAGE_ is set. Furthermore, there won't be a call to find_package if #18961 gets merged so this will indeed be a bug.

The job of VCPKG_TRACE_FIND_PACKAGE is printing every call to find_package, If #18961 gets merged, find_package will not be called if CMAKE_DISABLE_FIND_PACKAGE_ is set, so VCPKG_TRACE_FIND_PACKAGE will not print log.
Should I labeled this issue to question?

[dg0yt]

There needs to be a decision if these calls shall be
logged as disabled (#28552 (comment))
or not logged at all (#28552 (comment)).

[LilyWangLL]

cc @vicroms

There needs to be a decision if these calls shall be logged as disabled (#28552 (comment)) or not logged at all (#28552 (comment)).

[github-actions]

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

[Thomas1664]

no stale

[github-actions]

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

[Thomas1664]

no stale

[github-actions]

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

[Thomas1664]

No stale

[dg0yt]

@vicroms This issue waits for a vcpkg team decision. #28552 (comment)