-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rmqcpp] build failure #38736
Comments
Unsupported means unsupported... |
Hi, of course I know, that bde is not supported for windows, but after last update of the port I can build it. |
…rm support (#39119) Fix incorrect entries of `scripts/ci.baseline.txt`. Fix #38787, won't fix downstream `rmqcpp` for #38736. * Keep skip in CI - Conflict dependencies `pcre2`, `ryu` in #32645 * Disable `android` - There is a weird error that failed to find `BdeBuildSystem/bbs_runtest.py` by `BdeBuildSystem/BdeBuildSystemConfig.cmake` * Disable `arm64-windows` - Failed with `groups\bsl\bsls\bsls_platform.h(419): fatal error C1189: #error: "Unable to identify CPU on which the MSVC compiler is running."` * Disable `uwp` - Failed with `groups\bdl\bdlb\bdlb_randomdevice.cpp(93): error C3861: 'CryptAcquireContext': identifier not found` * Check `scripts/ci.baseline.txt` - Checked by `Get-Content ./scripts/ci.baseline.txt | Select-String -NotMatch '^#' | Select-String -NotMatch ':(arm-neon-android|arm64-android|arm64-osx|arm64-uwp|arm64-windows|x64-android|x64-linux|x64-osx|x64-uwp|x64-windows|x64-windows-static|x64-windows-static-md|x86-windows)\s*='`
Bde is now supported on windows platform, but rmqcpp won't build. |
Same issue here on Arch ( Notes:
And here's the relevant tail of
|
I went and checked the build tree. basic_resolver_entry(const endpoint_type& ep,
BOOST_ASIO_STRING_VIEW_PARAM host, BOOST_ASIO_STRING_VIEW_PARAM service)
: endpoint_(ep),
host_name_(static_cast<std::string>(host)),
service_name_(static_cast<std::string>(service))
{
}
//
// detail/string_view.hpp
// ~~~~~~~~~~~~~~~~~~~~~~
//
// Copyright (c) 2003-2024 Christopher M. Kohlhoff (chris at kohlhoff dot com)
//
// Distributed under the Boost Software License, Version 1.0. (See accompanying
// file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
//
#ifndef BOOST_ASIO_DETAIL_STRING_VIEW_HPP
#define BOOST_ASIO_DETAIL_STRING_VIEW_HPP
#if defined(_MSC_VER) && (_MSC_VER >= 1200)
# pragma once
#endif // defined(_MSC_VER) && (_MSC_VER >= 1200)
#include <boost/asio/detail/config.hpp>
#if defined(BOOST_ASIO_HAS_STRING_VIEW)
#if defined(BOOST_ASIO_HAS_STD_STRING_VIEW)
# include <string_view>
#elif defined(BOOST_ASIO_HAS_STD_EXPERIMENTAL_STRING_VIEW)
# include <experimental/string_view>
#else // defined(BOOST_ASIO_HAS_STD_EXPERIMENTAL_STRING_VIEW)
# error BOOST_ASIO_HAS_STRING_VIEW is set but no string_view is available
#endif // defined(BOOST_ASIO_HAS_STD_EXPERIMENTAL_STRING_VIEW)
namespace boost {
namespace asio {
#if defined(BOOST_ASIO_HAS_STD_STRING_VIEW)
using std::basic_string_view;
using std::string_view;
#elif defined(BOOST_ASIO_HAS_STD_EXPERIMENTAL_STRING_VIEW)
using std::experimental::basic_string_view;
using std::experimental::string_view;
#endif // defined(BOOST_ASIO_HAS_STD_EXPERIMENTAL_STRING_VIEW)
} // namespace asio
} // namespace boost
# define BOOST_ASIO_STRING_VIEW_PARAM boost::asio::string_view
#else // defined(BOOST_ASIO_HAS_STRING_VIEW)
# define BOOST_ASIO_STRING_VIEW_PARAM const std::string&
#endif // defined(BOOST_ASIO_HAS_STRING_VIEW)
#endif // BOOST_ASIO_DETAIL_STRING_VIEW_HPP We can see that This edit fixes the calls, letting the compiler call the implicit constructor for either // Broken:
entries.push_back(entry_type(endpoint, host, port));
// Works:
entries.push_back(entry_type(endpoint, host.c_str(), port.c_str())); Save, run Now the question is: How do you apply the patch to get it right away without having to wait for this fix to be upstreamed ? 🤔 Edit: Looking at bloomberg/rmqcpp#43, the fix has been made, though using |
Sorry about the amount of force pushes, the PR is up with a working port! |
Operating system
Windows 11 Pro
Compiler
MSVC
Steps to reproduce the behavior
Failure logs
Package: rmqcpp:x64-windows@1.0.0
Host Environment
vcpkg-scripts version: f4456c1 2024-05-13 (34 hours ago)
To Reproduce
vcpkg install rmqcpp --allow-unsupported
Failure logs
D:\src\projects\vcpkgnugetgenerator\src\vcpkg\buildtrees\rmqcpp\build-x64-windows-dbg-out.log
Additional context
No response
The text was updated successfully, but these errors were encountered: