[tinyfiledialogs] build failure wrong hash ?

[TokyoSU]

Operating system

Windows

Compiler

MSVC 2022

Steps to reproduce the behavior

1) update to last master.
2) vcpkg install tinyfiledialogs:x64-windows
3) see many attempt to download it with many mirror and fail.

Failure logs

-- Note: tinyfiledialogs only supports static library linkage. Building static library.
Downloading tinyfiledialogs-current.zip, trying https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download
Trying https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=cfhcable
Trying https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=pilotfiber
Trying https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=gigenet
Trying https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=versaweb
Trying https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=ayera
Trying https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=netactuate
Trying https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=phoenixnap
Trying https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=astuteinternet
Trying https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=freefr
Trying https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=netcologne
Trying https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=deac-riga
Trying https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=excellmedia
Trying https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=iweb
Trying https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=jaist
Trying https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=jztkft
Trying https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=managedway
Trying https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=nchc
Trying https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=netix
Trying https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=ufpr
Trying https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=tenet
C:\Users\vleva\Documents\GitHub\vcpkg\downloads\tinyfiledialogs-current.zip.135648.part: error: download from https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download had an unexpected hash
note: Expected: 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03
note: Actual : d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f
C:\Users\vleva\Documents\GitHub\vcpkg\downloads\tinyfiledialogs-current.zip.135648.part: error: download from https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=cfhcable had an unexpected hash
note: Expected: 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03
note: Actual : d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f
C:\Users\vleva\Documents\GitHub\vcpkg\downloads\tinyfiledialogs-current.zip.135648.part: error: download from https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=pilotfiber had an unexpected hash
note: Expected: 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03
note: Actual : d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f
C:\Users\vleva\Documents\GitHub\vcpkg\downloads\tinyfiledialogs-current.zip.135648.part: error: download from https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=gigenet had an unexpected hash
note: Expected: 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03
note: Actual : d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f
C:\Users\vleva\Documents\GitHub\vcpkg\downloads\tinyfiledialogs-current.zip.135648.part: error: download from https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=versaweb had an unexpected hash
note: Expected: 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03
note: Actual : d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f
C:\Users\vleva\Documents\GitHub\vcpkg\downloads\tinyfiledialogs-current.zip.135648.part: error: download from https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=ayera had an unexpected hash
note: Expected: 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03
note: Actual : d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f
C:\Users\vleva\Documents\GitHub\vcpkg\downloads\tinyfiledialogs-current.zip.135648.part: error: download from https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=netactuate had an unexpected hash
note: Expected: 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03
note: Actual : d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f
C:\Users\vleva\Documents\GitHub\vcpkg\downloads\tinyfiledialogs-current.zip.135648.part: error: download from https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=phoenixnap had an unexpected hash
note: Expected: 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03
note: Actual : d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f
C:\Users\vleva\Documents\GitHub\vcpkg\downloads\tinyfiledialogs-current.zip.135648.part: error: download from https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=astuteinternet had an unexpected hash
note: Expected: 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03
note: Actual : d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f
C:\Users\vleva\Documents\GitHub\vcpkg\downloads\tinyfiledialogs-current.zip.135648.part: error: download from https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=freefr had an unexpected hash
note: Expected: 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03
note: Actual : d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f
C:\Users\vleva\Documents\GitHub\vcpkg\downloads\tinyfiledialogs-current.zip.135648.part: error: download from https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=netcologne had an unexpected hash
note: Expected: 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03
note: Actual : d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f
C:\Users\vleva\Documents\GitHub\vcpkg\downloads\tinyfiledialogs-current.zip.135648.part: error: download from https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=deac-riga had an unexpected hash
note: Expected: 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03
note: Actual : d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f
C:\Users\vleva\Documents\GitHub\vcpkg\downloads\tinyfiledialogs-current.zip.135648.part: error: download from https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=excellmedia had an unexpected hash
note: Expected: 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03
note: Actual : d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f
C:\Users\vleva\Documents\GitHub\vcpkg\downloads\tinyfiledialogs-current.zip.135648.part: error: download from https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=iweb had an unexpected hash
note: Expected: 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03
note: Actual : d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f
C:\Users\vleva\Documents\GitHub\vcpkg\downloads\tinyfiledialogs-current.zip.135648.part: error: download from https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=jaist had an unexpected hash
note: Expected: 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03
note: Actual : d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f
C:\Users\vleva\Documents\GitHub\vcpkg\downloads\tinyfiledialogs-current.zip.135648.part: error: download from https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=jztkft had an unexpected hash
note: Expected: 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03
note: Actual : d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f
C:\Users\vleva\Documents\GitHub\vcpkg\downloads\tinyfiledialogs-current.zip.135648.part: error: download from https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=managedway had an unexpected hash
note: Expected: 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03
note: Actual : d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f
C:\Users\vleva\Documents\GitHub\vcpkg\downloads\tinyfiledialogs-current.zip.135648.part: error: download from https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=nchc had an unexpected hash
note: Expected: 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03
note: Actual : d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f
C:\Users\vleva\Documents\GitHub\vcpkg\downloads\tinyfiledialogs-current.zip.135648.part: error: download from https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=netix had an unexpected hash
note: Expected: 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03
note: Actual : d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f
C:\Users\vleva\Documents\GitHub\vcpkg\downloads\tinyfiledialogs-current.zip.135648.part: error: download from https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=ufpr had an unexpected hash
note: Expected: 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03
note: Actual : d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f
C:\Users\vleva\Documents\GitHub\vcpkg\downloads\tinyfiledialogs-current.zip.135648.part: error: download from https://sourceforge.net/projects/tinyfiledialogs//files/tinyfiledialogs-current.zip/download?use_mirror=tenet had an unexpected hash
note: Expected: 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03
note: Actual : d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:231 (message):
Download failed, halting portfile.
Call Stack (most recent call first):
scripts/cmake/vcpkg_download_sourceforge.cmake:78 (vcpkg_download_distfile)
scripts/cmake/vcpkg_from_sourceforge.cmake:21 (vcpkg_download_sourceforge)
ports/tinyfiledialogs/portfile.cmake:3 (vcpkg_from_sourceforge)
scripts/ports.cmake:196 (include)

Additional context

No response

[TokyoSU]

I suppose this is the cause: #43413 since it's the last PR added for tinyfiledialogs.
I think the hash should be d7ddd37576d8d758a7bccc25cc19698d5c87645b72aaa1dd2cad32abc8c342911764ef3ab14037d1abcb255f2919fccc1bec07118c81977a89d1f7fda70f185f not 6e890014646e69f0002a342d6331ec03dc41749a760dd30ac8a99919adbfc8ba646f988d1f44b0c1991a075d9cd054e481014c8cc8c5e9e8ec56ce2600d6fb03

[MonicaLiu0311]

https://sourceforge.net/projects/tinyfiledialogs/files/tinyfiledialogs-current.zip

The upstream has not released the stable version, this link will always dowload the latest verison. It is not that the hash is wrong, but that upstream has newly released version 3.19.0. So this port needs to update.

[dg0yt]

The upstream has not released the stable version, this link will always dowload the latest verison. It is not that the hash is wrong, but that upstream has newly released version 3.19.0. So this port needs to update.

This is how upstream releases the latest version: updating the existing tarball, which changes the SHA512, which makes it unsuitable for vcpkg asset caching.

Better approach in #43571.

[BillyONeal]

which makes it unsuitable for vcpkg asset caching

I would argue that it is suitable for asset caching, as if an asset cache is configured one is insulated from this problem. But I still like your fix :)

[dg0yt]

Yeah, the problem isn't that the zip file isn't cachable. The problem is that the source URL doesn't reliable identify a particular content. Even a git ref is more suitable to identify a particular content, but vcpkg isn't capable to cache that.