Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tinyfiledialogs] Update and switch to zip download. #43413

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

BillyONeal
Copy link
Member

Resolves zip download failure due to vcpkg_from_git being unable to be asset cached. Example: https://dev.azure.com/vcpkg/public/_build/results?buildId=111706

Building tinyfiledialogs:arm-neon-android@3.8.8#4... -- Fetching https://git.code.sf.net/p/tinyfiledialogs/code master... CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:127 (message):
    Command failed: /usr/bin/git fetch https://git.code.sf.net/p/tinyfiledialogs/code master -n
    Working Directory: /vcpkg/downloads/git-tmp
    Error code: 128
    See logs for more information:
      /mnt/vcpkg-ci/b/tinyfiledialogs/git-fetch-arm-neon-android-err.log

[...]
remote: error: unable to open object pack directory: ./objects/pack: Transport endpoint is not connected remote: fatal: failed to read object e6f86deb8bab8e2c560587726635e4f7c34ba659: Transport endpoint is not connected remote: aborting due to possible repository corruption on the remote side. fatal: protocol error: bad pack header
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version. as far as I know
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Resolves zip download failure due to vcpkg_from_git being unable to be asset cached. Example: https://dev.azure.com/vcpkg/public/_build/results?buildId=111706

Building tinyfiledialogs:arm-neon-android@3.8.8#4...
-- Fetching https://git.code.sf.net/p/tinyfiledialogs/code master...
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:127 (message):
    Command failed: /usr/bin/git fetch https://git.code.sf.net/p/tinyfiledialogs/code master -n
    Working Directory: /vcpkg/downloads/git-tmp
    Error code: 128
    See logs for more information:
      /mnt/vcpkg-ci/b/tinyfiledialogs/git-fetch-arm-neon-android-err.log

[...]
remote: error: unable to open object pack directory: ./objects/pack: Transport endpoint is not connected
remote: fatal: failed to read object e6f86deb8bab8e2c560587726635e4f7c34ba659: Transport endpoint is not connected
remote: aborting due to possible repository corruption on the remote side.
fatal: protocol error: bad pack header
@BillyONeal BillyONeal added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Jan 22, 2025
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Jan 23, 2025
@vicroms vicroms merged commit 94d51c1 into microsoft:master Jan 23, 2025
17 checks passed
@BillyONeal BillyONeal deleted the tinyfiledialogs-zip branch January 23, 2025 22:26
URL https://git.code.sf.net/p/tinyfiledialogs/code
REF e11f94cd7887b101d64f74892d769f0139b5e166
REPO tinyfiledialogs
FILENAME tinyfiledialogs-current.zip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a moving target, isn't it? -> #43483

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants