Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pcl] update to 1.10 #9765

Closed
traversaro opened this issue Jan 20, 2020 · 7 comments
Closed

[pcl] update to 1.10 #9765

traversaro opened this issue Jan 20, 2020 · 7 comments
Assignees
Labels
category:port-update The issue is with a library, which is requesting update new revision

Comments

@traversaro
Copy link
Contributor

traversaro commented Jan 20, 2020

Library name: PCL (Point Cloud Library)

New version number: 1.10.0

Other information that may be useful (release notes, etc...):

@traversaro traversaro added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jan 20, 2020
@AlvinZhangH AlvinZhangH added category:port-update The issue is with a library, which is requesting update new revision and removed category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Jan 21, 2020
@Neumann-A
Copy link
Contributor

included in #9202 to fix the PCL regression.
VTK option is disabled until they fix PointCloudLibrary/pcl#3408

@NancyLi1013
Copy link
Contributor

@Neumann-A Thanks for your update.

@aslze
Copy link

aslze commented May 20, 2020

PCL 1.11 is already out. Maybe we should aim at this instead of 1.10.

https://github.com/PointCloudLibrary/pcl/releases/tag/pcl-1.11.0

They finally got rid of boost::shared_ptr and use std::shared_ptr.

@aslze
Copy link

aslze commented May 20, 2020

And, well, in the mean time, if the upgrade is hard, we can apply this commit as a patch, which fixed a bug after 1.9.1 was released, but before 1.10:

PointCloudLibrary/pcl@36c2bd6

I'm not sure how to do that. Create a .patch file from there and add it to the port file? What is the "index" (second line) in patch files? It's the only part I can't figure out.

@NancyLi1013
Copy link
Contributor

Hi @aslze
Thanks for your above info. I will check this later.

@NancyLi1013
Copy link
Contributor

@aslze
PCL will be updated via #10042. You can rebuild it based on this PR.

@NancyLi1013
Copy link
Contributor

I'm closing this issue for now since it has been updated to 1.11.0.
Please update vcpkg to the latest version and rebuild it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

No branches or pull requests

5 participants