[CGNS/ParaView] Add new ports #9960

Neumann-A · 2020-02-07T10:04:35Z

~~loses #9765~~ should be seperate PR
closes #5330
closes #11331
closes #9180

TODO:

Check features and other Platforms.
Check remaining Patches.
Python feature + patches.
Redo Qt static plugin patches. (if desired. are not required starting with Qt 5.14)

~~Current Status: Should built and install. Might fail within portfile or post build checks.~~

MVoz · 2020-03-01T09:09:06Z

vcpkg install CGNS[*]:x64-windows

Package hdf5 does not have a mpi feature

there is no mpi support word in hdf5, there is a parallel

vcpkg install hdf5[core,parallel,szip,tools,zlib]:x64-windows

Build-Depends: hdf5[mpi] -->> hdf5[parallel]

vcpkg install cgns[core,hdf5,legacy,lfs,lfsselector,tools]:x64-windows --recurse
Computing installation plan...
The following packages will be built and installed:
    cgns[core,hdf5,legacy,lfs,lfsselector,tools]:x64-windows
Starting package 1/1: cgns:x64-windows
Building package cgns[core,hdf5,legacy,lfs,lfsselector,tools]:x64-windows...
-- Using cached E:/tools/vcpkg/downloads/CGNS-CGNS-3420e23febf0eb38c1b05af3c157d614d8476557.tar.gz
-- Using source at E:/tools/vcpkg/buildtrees/cgns/src/14d8476557-c37af86822
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Installing: E:/tools/vcpkg/packages/cgns_x64-windows/share/cgns/cgnsBuild.defs
-- Installing: E:/tools/vcpkg/packages/cgns_x64-windows/include/cgnsconfig.h
-- Installing: E:/tools/vcpkg/packages/cgns_x64-windows/tools/cgns/cgnscheck.exe
-- Installing: E:/tools/vcpkg/packages/cgns_x64-windows/tools/cgns/cgnscompress.exe
-- Installing: E:/tools/vcpkg/packages/cgns_x64-windows/tools/cgns/cgnsconvert.exe
-- Installing: E:/tools/vcpkg/packages/cgns_x64-windows/tools/cgns/cgnsdiff.exe
-- Installing: E:/tools/vcpkg/packages/cgns_x64-windows/tools/cgns/cgnslist.exe
-- Installing: E:/tools/vcpkg/packages/cgns_x64-windows/tools/cgns/cgnsnames.exe
-- Installing: E:/tools/vcpkg/packages/cgns_x64-windows/share/cgns/copyright
-- Performing post-build validation
-- Performing post-build validation done
Building package cgns[core,hdf5,legacy,lfs,lfsselector,tools]:x64-windows... done
Installing package cgns[core,hdf5,legacy,lfs,lfsselector,tools]:x64-windows...
Installing package cgns[core,hdf5,legacy,lfs,lfsselector,tools]:x64-windows... done

JackBoosY · 2020-03-02T03:11:58Z

/azp run

azure-pipelines · 2020-03-02T03:12:03Z

Pull request contains merge conflicts.

Neumann-A · 2020-03-03T14:33:28Z

hmmm Qt5X11Extras is still not building in CI..... so something is missing when it tries to build qt5-x11extras and it just does nothing but still succeeds.

JackBoosY · 2020-03-04T02:22:58Z

@Neumann-A I think it has something to do with building queues.

larshg · 2020-03-18T09:09:20Z

What is the status of this - its getting tiresome, that VTK links to the wrong libraries. Can I help in any way?

Using VS2019 on windows.

Neumann-A · 2020-03-18T09:15:16Z

@larshg On windows according to CI and my tests this should just work fine. Linux and OSX CI are kind of a problem.

larshg · 2020-03-18T21:04:32Z

@Neumann-A I have merged this PR and is at least build sucessfully, but I noticed i says 8.9 - is it head of VTK that get compiled?
Is it possible to use 8.2 for starters?
Else I have to start working on this :)

Neumann-A · 2020-03-18T21:21:41Z

@larshg: No PV does not compile with VTK 8.2 due to changes in API. Furthermore they completely rewrote their CMake module system so that it correctly works with CMake targets.
It is not head of VTK but the version used by PV release 5.7 which seems to be good enough for a ParaView release; ) Unfortunately the different VTK/ITK/PV/vtk-m/etc. don't coordinate their release tags/schedules although I saw somewhere on their gitlab an issue about that and a plan to make coordinates releases in the future.

larshg · 2020-03-19T10:34:27Z

So there won't be any correct Cmake configs for the 8.2 version, that is currently present in VCPKG I guess? Even after this is merged?

Neumann-A · 2020-03-19T10:48:58Z

@larshg: At least not from me. I am not going to fix the VTK 8.2 CMake mess, I once tried but gave up due to the amount of thinks which needed to be fixed. But I really like their new module system.

larshg · 2020-03-19T10:51:53Z

@Neumann-A Okay, maybe I'll try look into it.

JackBoosY · 2020-03-20T02:23:35Z

/azp run

azure-pipelines · 2020-03-20T02:23:55Z

Pull request contains merge conflicts.

JackBoosY · 2020-03-26T05:40:27Z

/azp run

azure-pipelines · 2020-03-26T05:40:31Z

Pull request contains merge conflicts.

azure-pipelines · 2020-03-26T05:40:31Z

Pull request contains merge conflicts.

JackBoosY · 2020-03-26T05:40:48Z

Please resolve conflicts.

Thanks.

ports/paraview/CONTROL

JackBoosY · 2020-05-22T08:20:54Z

@Neumann-A Just replace the label name.

JackBoosY · 2020-06-03T08:47:57Z

When building cgns[mpi,fortran,tests,tools,hdf5,lfsselector,lfs,legacy]:

CMake Error at CMakeLists.txt:117 (enable_language):
  The Ninja generator does not support Fortran using Ninja version

    1.8.2

  due to lack of required features.  Kitware has implemented the required
  features but as of this version of CMake they have not been integrated to
  upstream ninja.  Pending integration, Kitware maintains a branch at:

    https://github.com/Kitware/ninja/tree/features-for-fortran#readme

  with the required features.  One may build ninja from that branch to get
  support for Fortran.

Should we update ninja version?

Neumann-A · 2020-06-03T09:00:16Z

@JackBoosY: internal version in vcpkg is already 1.10. vcpkg is picking up the wrong one for you

JackBoosY · 2020-06-05T05:44:31Z

When building .\vcpkg.exe install vtk[vtkm,openvr,qt,mpi,python,atlmfc,paraview,cuda,all]:x64-windows:

CMake Error at CMake/vtkDownload.cmake:8 (message):
  Attempted to download Module_MomentInvariants when VTK_FORBID_DOWNLOADS is
  ON
Call Stack (most recent call first):
  CMake/vtkModuleRemote.cmake:142 (vtk_download_attempt_check)
  Remote/MomentInvariants.remote.cmake:5 (vtk_fetch_module)
  Remote/CMakeLists.txt:9 (include)

mathstuf · 2020-06-05T11:58:51Z

9.0.1 will have this patch which allows you to fix that: https://gitlab.kitware.com/vtk/vtk/-/merge_requests/6914

Neumann-A · 2020-06-05T13:59:43Z

@JackBoosY: VTK_FORBID_DOWNLOADS was already there before I touched the port. Git blame tells me that @ras0219-msft was the one adding it in 3ee7045. I don't really know why because VTKs remote module seems to be locked to a certain version. So turning it on should not be a problem.
This probably also means that the all feature has been broken for a long time within master and should not block this PR.

mathstuf · 2020-06-05T14:19:25Z

Note that I don't really consider the remote modules part of VTK. I want them to either be in VTK or out (especially now that VTK's install tree is much more well-behaved). Not this half way thing. But, politics are involved, so it's not a fast process :) .

dan-shaw

LGTM, maybe needs another review

JackBoosY · 2020-06-12T05:58:15Z

Please resolve the file conflicts.

# Conflicts: # ports/vtk/CONTROL # ports/vtk/portfile.cmake

Neumann-A · 2020-06-12T08:07:10Z

@JackBoosY: Done

Neumann-A mentioned this pull request Feb 7, 2020

[VTK-m/VTK/ParaView] Add new port (might work now) #9202

Closed

PhoebeHui assigned JackBoosY, PhoebeHui and NancyLi1013 Feb 7, 2020

Neumann-A mentioned this pull request Feb 10, 2020

[Qt5] Update Qt latest to 5.14.1 #10009

Closed

larshg mentioned this pull request Mar 23, 2020

Fix VTK duplicate linking libraries #10518

Closed

Neumann-A mentioned this pull request May 3, 2020

[VTK/vtk-m] Update VTK to 9.0 and add vtk-m #11148

Merged

Neumann-A added 2 commits May 11, 2020 22:53

[cgns] add port cgns

cfc3223

[paraview] add new port

38bb147

Neumann-A force-pushed the extract_paraview_pr branch from fcbb89e to 38bb147 Compare May 11, 2020 20:59

Neumann-A changed the title ~~[VTK-m/VTK/ParaView] Add new port (might work now)~~ [ParaView] Add new port (might work now) May 11, 2020

[paraview] correct dependencies; disable catalyst

aa4e06d

Neumann-A mentioned this pull request May 22, 2020

[opencv4] Fix linking halide #11429

Merged

JackBoosY suggested changes May 22, 2020

View reviewed changes

ports/paraview/CONTROL Outdated Show resolved Hide resolved

Update ports/paraview/CONTROL

93ee65c

JackBoosY added requires:testing Needs tests added before merging and removed requires:discussion labels May 22, 2020

JackBoosY added info:reviewed Pull Request changes follow basic guidelines requires:discussion and removed requires:testing Needs tests added before merging labels Jun 8, 2020

JackBoosY approved these changes Jun 8, 2020

View reviewed changes

dan-shaw approved these changes Jun 12, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into extract_paraview_pr

6517a62

# Conflicts: # ports/vtk/CONTROL # ports/vtk/portfile.cmake

JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed info:reviewed Pull Request changes follow basic guidelines labels Jun 12, 2020

dan-shaw merged commit 03766d0 into microsoft:master Jun 23, 2020

Neumann-A deleted the extract_paraview_pr branch June 23, 2020 17:58

Neumann-A mentioned this pull request Jul 3, 2020

[vtk] update to 9.0.1 #12149

Merged

NancyLi1013 mentioned this pull request Jul 16, 2020

[New Port Request] CGNS #9181

Closed

Neumann-A mentioned this pull request Aug 10, 2020

[OpenCV] fix compatibility with VTK9 #12785

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CGNS/ParaView] Add new ports #9960

[CGNS/ParaView] Add new ports #9960

Neumann-A commented Feb 7, 2020 •

edited

Loading

MVoz commented Mar 1, 2020

JackBoosY commented Mar 2, 2020

azure-pipelines bot commented Mar 2, 2020

Neumann-A commented Mar 3, 2020

JackBoosY commented Mar 4, 2020

larshg commented Mar 18, 2020 •

edited

Loading

Neumann-A commented Mar 18, 2020

larshg commented Mar 18, 2020

Neumann-A commented Mar 18, 2020

larshg commented Mar 19, 2020

Neumann-A commented Mar 19, 2020

larshg commented Mar 19, 2020

JackBoosY commented Mar 20, 2020

azure-pipelines bot commented Mar 20, 2020

JackBoosY commented Mar 26, 2020

azure-pipelines bot commented Mar 26, 2020

azure-pipelines bot commented Mar 26, 2020

JackBoosY commented Mar 26, 2020

JackBoosY commented May 22, 2020

JackBoosY commented Jun 3, 2020

Neumann-A commented Jun 3, 2020

JackBoosY commented Jun 5, 2020

mathstuf commented Jun 5, 2020

Neumann-A commented Jun 5, 2020

mathstuf commented Jun 5, 2020

dan-shaw left a comment

JackBoosY commented Jun 12, 2020

Neumann-A commented Jun 12, 2020

[CGNS/ParaView] Add new ports #9960

[CGNS/ParaView] Add new ports #9960

Conversation

Neumann-A commented Feb 7, 2020 • edited Loading

MVoz commented Mar 1, 2020

JackBoosY commented Mar 2, 2020

azure-pipelines bot commented Mar 2, 2020

Neumann-A commented Mar 3, 2020

JackBoosY commented Mar 4, 2020

larshg commented Mar 18, 2020 • edited Loading

Neumann-A commented Mar 18, 2020

larshg commented Mar 18, 2020

Neumann-A commented Mar 18, 2020

larshg commented Mar 19, 2020

Neumann-A commented Mar 19, 2020

larshg commented Mar 19, 2020

JackBoosY commented Mar 20, 2020

azure-pipelines bot commented Mar 20, 2020

JackBoosY commented Mar 26, 2020

azure-pipelines bot commented Mar 26, 2020

azure-pipelines bot commented Mar 26, 2020

JackBoosY commented Mar 26, 2020

JackBoosY commented May 22, 2020

JackBoosY commented Jun 3, 2020

Neumann-A commented Jun 3, 2020

JackBoosY commented Jun 5, 2020

mathstuf commented Jun 5, 2020

Neumann-A commented Jun 5, 2020

mathstuf commented Jun 5, 2020

dan-shaw left a comment

Choose a reason for hiding this comment

JackBoosY commented Jun 12, 2020

Neumann-A commented Jun 12, 2020

Neumann-A commented Feb 7, 2020 •

edited

Loading

larshg commented Mar 18, 2020 •

edited

Loading