Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libbson/mongo-c-driver] Update to 1.16.1 #10010

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Feb 10, 2020

I updated the patch of mongo-c-driver, fixed the issue of using the built-in libbson and built a static library while building a dynamic library.

Related: #9986

Note: All features passed in the following triplets test:

  • x86-windows
  • x64-windows
  • x64-windows-static

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Feb 10, 2020
@JackBoosY JackBoosY marked this pull request as ready for review February 10, 2020 14:34
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Feb 12, 2020
ports/libbson/usage Outdated Show resolved Hide resolved
ports/libbson/usage Outdated Show resolved Hide resolved
@PhoebeHui PhoebeHui added waiting for response and removed info:reviewed Pull Request changes follow basic guidelines labels Feb 14, 2020
@JackBoosY
Copy link
Contributor Author

@ras0219-msft @PhoebeHui Ready to review now.

ports/libbson/CONTROL Outdated Show resolved Hide resolved
ports/libbson/portfile.cmake Outdated Show resolved Hide resolved
ports/mongo-c-driver/CONTROL Outdated Show resolved Hide resolved
ports/mongo-c-driver/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY JackBoosY requested a review from PhoebeHui March 5, 2020 02:46
@JackBoosY
Copy link
Contributor Author

/azp run

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Apr 2, 2020
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil
Copy link
Contributor

LGTM! Thanks Jack :)

@strega-nil strega-nil merged commit 26577fd into microsoft:master May 1, 2020
@JackBoosY JackBoosY deleted the dev/jack/update_mogocdriver_libbson_1.16.1 branch May 6, 2020 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants