[gts] Support for build with cmake in unix #10055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
/azp run |
1 similar comment
|
/azp run |
PhoebeHui
approved these changes
Feb 20, 2020
dan-shaw
added
info:reviewed
dan-shaw
approved these changes
Mar 20, 2020
|
/azp run |
dan-shaw
added
waiting for response
and removed
info:reviewed
|
@JackBoosY CI fails on Linux |
|
@dan-shaw Re-run and the test was successful. |
|
Should the CI baseline be updated and remove |
dan-shaw
added
waiting for response
and removed
info:reviewed
|
/azp run |
|
/azp run |
|
@dan-shaw Ready to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
CMakeLists.txtdoes not support building in UNIX, so add support.Realted: #9784.
Note: this port doesn't contain any features.