[bond] updated version + added bond-over-grpc integration as feature #10319

eitanhs · 2020-03-05T22:47:20Z

Describe the pull request

What does your PR fix?
Fixes bond - please support building with DBOND_ENABLE_GRPC=TRUE #10316
Which triplets are supported/not supported? Have you updated the CI baseline?
currently tested internally against windows-x64 but should work with other triplets without modifications. Didn't update the CI baseline.
Does your PR follow the maintainer guide?
As much as I could, I'm not a C-Make pro so I'm not sure if and what I could have done better.

* added bond-over-grpc integration as feature

msftclas · 2020-03-05T22:47:33Z

All CLA requirements met.

ras0219-msft · 2020-03-18T18:28:04Z

/azp run

dan-shaw · 2020-03-19T21:51:05Z

/azp run

…ure/bond_with_grpc

ports/bond/portfile.cmake

chwarr · 2020-05-14T18:30:07Z

ports/bond/skip-grpc-compilation.patch

@@ -0,0 +1,11 @@
+diff --git a/thirdparty/CMakeLists.txt b/thirdparty/CMakeLists.txt


We would be happy to take this functionality of skipping gRPC compilation upstream were you to contribute it behind a CMake variable.

with vcpkg_check_features

LilyWangL · 2020-05-18T07:05:58Z

@eitanhs Now this port build failed on Linux with the following error:

CMake Error at stack_build.cmake:21 (message):
  Version 2.3.1, Git revision de2a7b694f07de7e6cf17f8c92338c16286b2878 (8103
  commits) x86_64 hpack-0.33.0

  2020-05-15 11:23:37.473592: [debug] Checking for project config at:
  /mnt/_work/1/s/buildtrees/bond/src/8.2.0-6f74198761/compiler/stack.yaml

  2020-05-15 11:23:37.479173: [debug] Loading project config file stack.yaml

  2020-05-15 11:23:37.499447: [error] Preventing creation of stack root
  '/home/root/.stack/'.  Parent directory '/home/root/' is owned by someone
  else.

chwarr · 2020-05-18T17:58:39Z

In the Bond CI builds themselves, we have to use cmake -DBOND_STACK_OPTIONS="--allow-different-user" ...

eitanhs · 2020-05-18T18:51:13Z

In the Bond CI builds themselves, we have to use cmake -DBOND_STACK_OPTIONS="--allow-different-user" ...

can I turn this flag regardless of the compiling platform? meaning, just add it to the options list in the portfile?

chwarr · 2020-05-18T20:00:31Z

In the Bond CI builds themselves, we have to use cmake -DBOND_STACK_OPTIONS="--allow-different-user" ...

can I turn this flag regardless of the compiling platform? meaning, just add it to the options list in the portfile?

Seems to work fine on Windows. I just tested it with stack version 2.1.3 on Windows 10 (cd compiler; stack compile --allow-different-user) and everything built fine.

The documentation for --allow-different-user says "POSIX systems only." I guess that means that on non-POSIX systems or just doesn't do anything rather than causing a failure.

…ure/bond_with_grpc

eitanhs · 2020-05-19T08:02:01Z

/azp run

azure-pipelines · 2020-05-19T08:02:06Z

Commenter does not have sufficient privileges for PR 10319 in repo microsoft/vcpkg

eitanhs · 2020-05-19T08:06:11Z

@eitanhs Now this port build failed on Linux with the following error:
...

@LilyWangL, I thought I fixed it by applying the relevant flag @chwarr suggested.
Unfortunatley the build still fails on Azure Pipelines.
I did not see where is the actual error messages in the build? it shows only summary,
Can you post a link please so I can address the issues?

Thanks.

LilyWangL · 2020-05-21T02:15:44Z

/azp run

azure-pipelines · 2020-05-21T02:15:52Z

Azure Pipelines successfully started running 1 pipeline(s).

LilyWangL · 2020-05-21T06:02:09Z

@eitanhs The Linux error:

CMake Error at stack_build.cmake:21 (message):
  Invalid argument `"--allow-different-user"'

  Auxiliary command not found in path `stack-"--allow-different-user"'

  File does not exist or is not a regular file `"--allow-different-user"'

  Usage: stack [--help] [--version] [--numeric-version]
  [--hpack-numeric-version]

               [--docker*] [--nix*] ([--verbosity VERBOSITY] | [-v|--verbose] |
               [--silent]) [--[no-]time-in-log] [--stack-root STACK-ROOT]
               [--work-dir WORK-DIR] [--[no-]system-ghc] [--[no-]install-ghc]
               [--arch ARCH] [--ghc-variant VARIANT] [--ghc-build BUILD]
               [-j|--jobs JOBS] [--extra-include-dirs DIR] [--extra-lib-dirs DIR]
               [--with-gcc PATH-TO-GCC] [--with-hpack HPACK]
               [--[no-]skip-ghc-check] [--[no-]skip-msys] [--local-bin-path DIR]
               [--setup-info-yaml URL] [--[no-]modify-code-page]
               [--[no-]allow-different-user] [--[no-]dump-logs]
               [--color|--colour WHEN] [--resolver RESOLVER] [--compiler COMPILER]
               [--[no-]terminal] [--stack-colors|--stack-colours STYLES]
               [--terminal-width INT] [--stack-yaml STACK-YAML] [--lock-file ARG]
               COMMAND|FILE
ninja: build stopped: subcommand failed.

You could get the error log from here: https://dev.azure.com/vcpkg/public/_build/results?buildId=37392&view=logs&jobId=f79cfdd7-47a8-597f-8f57-dc3e21a8f2ad

eitanhs · 2020-05-21T06:15:25Z

Thanks, I'll try to setup a Linux machine so I'll be able to test it locally before pushing...

+ using gbc@0.12.0.1 tag that includes relevant build fixes

eitanhs · 2020-05-21T12:10:13Z

I'm unable to re-produce the same error the Azure Piplines get.
I guess I hit this isse: commercialhaskell/stack#2187 (since the pipleines are running inside docker containers(?))
Not sure how to tackle this :(

chwarr · 2020-05-21T16:33:36Z

@LilyWangL, what version of stack is on the vcpkg VMs? I think it's old enough that it doesn't have the --allow-different-user switch.

Below is what I see when I pass an invalid switch to stack Version 2.3.1, Git revision de2a7b694f07de7e6cf17f8c92338c16286b2878. Notice that it has [--[no-]allow-different-user]. The error that LilyWangL shared doesn't include that in the help text.

The stack documentation says this switch was added in 1.0.1.

We also know that Bond has trouble with anything below stack 1.5.1. If the stack version is old, is there a way to get it updated?

2020-05-21 9:28:00 AM (2020-05-21 16:28:00Z) :: chwarr@CHWARR-SL2 :: C:\src
  > stack --not-a-valid-switch
Invalid option `--not-a-valid-switch'

Usage: stack.exe [--help] [--version] [--numeric-version]
                 [--hpack-numeric-version] [--docker*] [--nix*]
                 ([--verbosity VERBOSITY] | [-v|--verbose] | [--silent])
                 [--[no-]time-in-log] [--stack-root STACK-ROOT]
                 [--work-dir WORK-DIR] [--[no-]system-ghc] [--[no-]install-ghc]
                 [--arch ARCH] [--ghc-variant VARIANT] [--ghc-build BUILD]
                 [-j|--jobs JOBS] [--extra-include-dirs DIR]
                 [--extra-lib-dirs DIR] [--with-gcc PATH-TO-GCC]
                 [--with-hpack HPACK] [--[no-]skip-ghc-check] [--[no-]skip-msys]
                 [--local-bin-path DIR] [--setup-info-yaml URL]
                 [--[no-]modify-code-page] [--[no-]allow-different-user]
                 [--[no-]dump-logs] [--color|--colour WHEN]
                 [--resolver RESOLVER] [--compiler COMPILER] [--[no-]terminal]
                 [--stack-colors|--stack-colours STYLES] [--terminal-width INT]
                 [--stack-yaml STACK-YAML] [--lock-file ARG] COMMAND|FILE

BillyONeal · 2020-05-22T03:56:26Z

/azp run

azure-pipelines · 2020-05-22T03:56:34Z

Azure Pipelines successfully started running 1 pipeline(s).

BillyONeal · 2020-05-26T05:34:15Z

#11569 See also, Bond's generated files are ill formed and don't work on VS2019 version 16.6.

chwarr · 2020-05-26T17:54:12Z

This is fixed in Bond's master branch. I'm publishing a 9.0 release with this fix today.

eitanhs · 2020-05-27T04:28:00Z

This is fixed in Bond's master branch. I'm publishing a 9.0 release with this fix today.

Thanks @chwarr !
After upgrading to the latest release all tests seems to pass!

…ure/bond_with_grpc

eitanhs · 2020-05-30T21:12:49Z

@LilyWangL - I think I addressed your comment. Can you please re-review?

* updated bond version

2913428

* added bond-over-grpc integration as feature

eitanhs closed this Mar 5, 2020

eitanhs deleted the feature/bond_with_grpc branch March 5, 2020 22:47

eitanhs restored the feature/bond_with_grpc branch March 5, 2020 22:49

eitanhs reopened this Mar 15, 2020

eitanhs mentioned this pull request Mar 15, 2020

bond - please support building with DBOND_ENABLE_GRPC=TRUE #10316

Closed

eitanhs changed the title * updated bond version [bond] updated version + added bond-over-grpc integration as feature Mar 21, 2020

PhoebeHui assigned LilyWangL May 14, 2020

Merge branch 'master' of https://github.com/microsoft/vcpkg into feat…

371ae47

…ure/bond_with_grpc

LilyWangL suggested changes May 14, 2020

View reviewed changes

ports/bond/portfile.cmake Show resolved Hide resolved

ports/bond/portfile.cmake Outdated Show resolved Hide resolved

LilyWangL added waiting for response and removed needs-feature-review labels May 14, 2020

chwarr reviewed May 14, 2020

View reviewed changes

replaced deprecated include(vcpkg_common_functions)

331ebe6

with vcpkg_check_features

eitanhs requested a review from LilyWangL May 15, 2020 11:23

eitanhs mentioned this pull request May 17, 2020

Feature/add cmake flag skip grpc lib compile microsoft/bond#1043

Closed

Eitan Har-Shoshanim added 2 commits May 19, 2020 10:48

fix 'stack' compilation under different user for POSIX systems

b16709a

Merge branch 'master' of https://github.com/microsoft/vcpkg into feat…

f8de7c4

…ure/bond_with_grpc

LilyWangL removed the waiting for response label May 21, 2020

+ removed redundant qoutes

c7ec522

+ using gbc@0.12.0.1 tag that includes relevant build fixes

Merge branch 'master' into feature/bond_with_grpc

d08983a

fix wrong hash for fetached archive under windows

1bba0ab

eitan added 2 commits May 27, 2020 05:37

upgrade to bond 9.0.0

cfcfc02

update gbc exec file name

dfe0160

This was referenced May 28, 2020

Bond update to 9.0.0 #11615

Closed

[bond] build failure on Visual Studio 16.6 #11569

Closed

eitanhs added 3 commits May 30, 2020 23:16

Merge branch 'master' of https://github.com/microsoft/vcpkg into feat…

c5eb611

…ure/bond_with_grpc

minor

c6ca278

fix wrong hash

cb466f9

LilyWangL approved these changes Jun 1, 2020

View reviewed changes

LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Jun 1, 2020

BillyONeal approved these changes Jun 2, 2020

View reviewed changes

BillyONeal merged commit a41c53c into microsoft:master Jun 2, 2020

eitanhs deleted the feature/bond_with_grpc branch June 3, 2020 04:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[bond] updated version + added bond-over-grpc integration as feature #10319

[bond] updated version + added bond-over-grpc integration as feature #10319

eitanhs commented Mar 5, 2020 •

edited by LilyWangL

Loading

msftclas commented Mar 5, 2020 •

edited

Loading

ras0219-msft commented Mar 18, 2020

dan-shaw commented Mar 19, 2020

chwarr May 14, 2020

LilyWangL commented May 18, 2020

chwarr commented May 18, 2020 •

edited

Loading

eitanhs commented May 18, 2020

chwarr commented May 18, 2020

eitanhs commented May 19, 2020

azure-pipelines bot commented May 19, 2020

eitanhs commented May 19, 2020

LilyWangL commented May 21, 2020

azure-pipelines bot commented May 21, 2020

LilyWangL commented May 21, 2020 •

edited

Loading

eitanhs commented May 21, 2020

eitanhs commented May 21, 2020

chwarr commented May 21, 2020

BillyONeal commented May 22, 2020

azure-pipelines bot commented May 22, 2020

BillyONeal commented May 26, 2020

chwarr commented May 26, 2020

eitanhs commented May 27, 2020

eitanhs commented May 30, 2020

		@@ -0,0 +1,11 @@
		diff --git a/thirdparty/CMakeLists.txt b/thirdparty/CMakeLists.txt

[bond] updated version + added bond-over-grpc integration as feature #10319

[bond] updated version + added bond-over-grpc integration as feature #10319

Conversation

eitanhs commented Mar 5, 2020 • edited by LilyWangL Loading

msftclas commented Mar 5, 2020 • edited Loading

ras0219-msft commented Mar 18, 2020

dan-shaw commented Mar 19, 2020

chwarr May 14, 2020

Choose a reason for hiding this comment

LilyWangL commented May 18, 2020

chwarr commented May 18, 2020 • edited Loading

eitanhs commented May 18, 2020

chwarr commented May 18, 2020

eitanhs commented May 19, 2020

azure-pipelines bot commented May 19, 2020

eitanhs commented May 19, 2020

LilyWangL commented May 21, 2020

azure-pipelines bot commented May 21, 2020

LilyWangL commented May 21, 2020 • edited Loading

eitanhs commented May 21, 2020

eitanhs commented May 21, 2020

chwarr commented May 21, 2020

BillyONeal commented May 22, 2020

azure-pipelines bot commented May 22, 2020

BillyONeal commented May 26, 2020

chwarr commented May 26, 2020

eitanhs commented May 27, 2020

eitanhs commented May 30, 2020

eitanhs commented Mar 5, 2020 •

edited by LilyWangL

Loading

msftclas commented Mar 5, 2020 •

edited

Loading

chwarr commented May 18, 2020 •

edited

Loading

LilyWangL commented May 21, 2020 •

edited

Loading