Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[geos] Upgrade to GEOS 3.6.4 #10377

Merged
merged 1 commit into from
Apr 27, 2020
Merged

[geos] Upgrade to GEOS 3.6.4 #10377

merged 1 commit into from
Apr 27, 2020

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Mar 11, 2020

Update port/geos to version 3.6.4, released 2019-10-04

See details in this release announcement

Note that this is not the current version, as I'd like to re-create each major version, so you can expect me to also create pull requests for GEOS versions 3.7.3 and 3.8.1 (current).


  • What does your PR fix? None.
  • Which triplets are supported/not supported? Have you updated the CI baseline? Not sure, and nope.
  • Does your PR follow the maintainer guide? Yes.

@msftclas
Copy link

msftclas commented Mar 11, 2020

CLA assistant check
All CLA requirements met.

ports/geos/portfile.cmake Outdated Show resolved Hide resolved
@mwtoews mwtoews force-pushed the geos branch 2 times, most recently from c69c063 to eae6f8b Compare March 11, 2020 20:21
@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Mar 12, 2020
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just needs a slight change. Thanks so much :)

ports/geos/CONTROL Outdated Show resolved Hide resolved
@dan-shaw
Copy link
Contributor

/azp run

1 similar comment
@dan-shaw
Copy link
Contributor

/azp run

@dan-shaw
Copy link
Contributor

@mwtoews @LilyWangL This is failing the CI for osg-qt. Do you know if this is a related error or an error with our CI?

@dan-shaw dan-shaw added waiting for response and removed info:reviewed Pull Request changes follow basic guidelines labels Mar 20, 2020
@LilyWangL
Copy link
Contributor

@mwtoews @LilyWangL This is failing the CI for osg-qt. Do you know if this is a related error or an error with our CI?

Port osg-qt build failed is not a related error with this PR.

@LilyWangL
Copy link
Contributor

/azp run

@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed waiting for response labels Apr 10, 2020
@mwtoews
Copy link
Contributor Author

mwtoews commented Apr 22, 2020

is this ready to merge yet?

@LilyWangL
Copy link
Contributor

@ras0219-msft This PR is ready to merge.

@ras0219-msft ras0219-msft merged commit 5c0c767 into microsoft:master Apr 27, 2020
@ras0219-msft
Copy link
Contributor

LGTM, thanks for this PR!

@jjpepper
Copy link

jjpepper commented May 20, 2020

Is GOES meant to be working? How is it meant to be used from CMake?

See example from their project: https://git.osgeo.org/gitea/geos/geos/src/branch/master/examples/client/CMakeLists.txt This doesn't work with vcpkg (even when the version number is removed). It would be great if Vcpkg could tell the user when a package is installed if special instructions are needed for linking etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants