Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[microsoft-signalr] Add new port #10833

Merged
merged 9 commits into from
May 15, 2020
Merged

[microsoft-signalr] Add new port #10833

merged 9 commits into from
May 15, 2020

Conversation

BrennanConroy
Copy link
Member

Describe the pull request

Adding the microsoft-signalr package to vcpkg.

@anurse @ras0219-msft

@LilyWangL LilyWangL changed the title Add microsoft-signalr package [microsoft-signalr] Add new port Apr 16, 2020
@LilyWangL LilyWangL assigned LilyWangL and unassigned PhoebeHui Apr 16, 2020
LilyWangL
LilyWangL suggested changes Apr 16, 2020
View reviewed changes
ports/microsoft-signalr/portfile.cmake Outdated Show resolved Hide resolved
ports/microsoft-signalr/portfile.cmake Outdated Show resolved Hide resolved
ports/microsoft-signalr/CONTROL Show resolved Hide resolved
@BrennanConroy
Copy link
Member Author

@LilyWangL This should be good now? The Linux failure looks like an infrastructure issue.

@LilyWangL
Copy link
Contributor

LilyWangL commented May 6, 2020 •
edited
Loading

@LilyWangL This should be good now? The Linux failure looks like an infrastructure issue.

Waiting for PR #11189 merge, this PR fix the CI baseline error.

@LilyWangL LilyWangL marked this pull request as ready for review May 12, 2020 09:26
@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label May 12, 2020
strega-nil
strega-nil suggested changes May 12, 2020
View reviewed changes
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change here to avoid silent failures; thanks so much!

ports/microsoft-signalr/CONTROL Outdated Show resolved Hide resolved
ports/microsoft-signalr/portfile.cmake Outdated Show resolved Hide resolved
ports/microsoft-signalr/portfile.cmake Outdated Show resolved Hide resolved
ports/microsoft-signalr/portfile.cmake Show resolved Hide resolved
@strega-nil strega-nil added waiting for response and removed info:reviewed Pull Request changes follow basic guidelines labels May 12, 2020
@strega-nil
Copy link
Contributor

Awesome, thanks so much! Are you comfortable with me merging now?

@strega-nil strega-nil added info:reviewed Pull Request changes follow basic guidelines and removed waiting for response labels May 13, 2020
@BrennanConroy
Copy link
Member Author

Yes please :)

Thanks for helping clean this up!

@strega-nil
Copy link
Contributor

Alright, awesome! Thanks @BrennanConroy :)

@strega-nil strega-nil merged commit b5a2581 into microsoft:master May 15, 2020
@BrennanConroy BrennanConroy deleted the brecon/signalr branch May 15, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil strega-nil strega-nil requested changes

@LilyWangL LilyWangL LilyWangL approved these changes

Assignees

@LilyWangL LilyWangL

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BrennanConroy @LilyWangL @strega-nil @PhoebeHui