Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ignition-modular-scripts] Migrate from Bitbucket to GitHub 🤖 #10858

Merged
merged 1 commit into from
May 7, 2020

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Apr 16, 2020

As announced in https://community.gazebosim.org/t/important-gazebo-and-ignition-are-going-to-github/533, the ignition project repositories have been migrated from Bitbucket to GitHub.

This commit updates the ignition_modular_library helpers to use GitHub instead of Bitbucket,
and also update the hashes of all the ignition ports as apparently the archive generated by GitHub
for releases are slightly different from the one generated by Bitbucket.

Describe the pull request

@traversaro
Copy link
Contributor Author

fyi @seanyen @j-rivero @chapulina

As announced in https://community.gazebosim.org/t/important-gazebo-and-ignition-are-going-to-github/533,
the ignition project repositories have been migrated from BitBucket to GitHub.

This commit updates the ignition_modular_library helpers to use GitHub instead of BitBucket,
and also update the hashes of all the ignition ports as apparently the archive generated by GitHub
for releases are slightly different from the one generated by BitBucket.
@traversaro traversaro changed the title [ignition-modular-scripts] Migrate from bitbucket to github 🤖 [ignition-modular-scripts] Migrate from Bitbucket to GitHub 🤖 Apr 16, 2020
@JackBoosY
Copy link
Contributor

Please resolve these regressions.

Thanks.

@traversaro
Copy link
Contributor Author

Please resolve these regressions.

Thanks.

Hi @JackBoosY, the regressions are due to the fact that vcpkg_from_github and vcpkg_from_bitbucket use the same name and the old bitbucket archive is still present in cache, as discussed in:

It is possible to solve the issue, but it would require changes to the vcpkg_from_github , so if you could provide a feedback on the two proposals in #10859 (comment) it would be great!

@JackBoosY
Copy link
Contributor

JackBoosY commented Apr 21, 2020

@traversaro Since vcpkg always chooses one repo to download source, I think we can delete the history in the baseline to solve this issue.

Does this PR need to wait for #10859 to merge before merging?

@traversaro
Copy link
Contributor Author

@traversaro Since vcpkg always chooses one repo to download source, I think we can delete the history in the baseline to solve this issue.

Great! There is any action needed on my side to do so?

Does this PR need to wait for #10859 to merge before merging?

No, they are completely independent.

@JackBoosY
Copy link
Contributor

@ras0219-msft Could you remove ignition-cmake_0.6.1.tar.gz from pipeline machine?

Thanks.

@traversaro
Copy link
Contributor Author

@ras0219-msft Could you remove ignition-cmake_0.6.1.tar.gz from pipeline machine?

Thanks.

Unfortunately I am afraid that the problem applies to all the ports that use the ignition_modular_library helper: https://github.com/microsoft/vcpkg/search?q=ignition_modular_library&unscoped_q=ignition_modular_library . Probably deleting all the archive that start with ignition- will be enough.

@strega-nil
Copy link
Contributor

Now that we're on new machines, we should be fine? hopefully?

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil strega-nil merged commit 5890810 into microsoft:master May 7, 2020
@strega-nil
Copy link
Contributor

Thanks @traversaro :D

@traversaro traversaro deleted the ignition-github-migration branch May 7, 2020 19:14
@traversaro
Copy link
Contributor Author

Thanks @traversaro :D

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants