-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ignition-modular-scripts] Migrate from Bitbucket to GitHub 🤖 #10858
[ignition-modular-scripts] Migrate from Bitbucket to GitHub 🤖 #10858
Conversation
As announced in https://community.gazebosim.org/t/important-gazebo-and-ignition-are-going-to-github/533, the ignition project repositories have been migrated from BitBucket to GitHub. This commit updates the ignition_modular_library helpers to use GitHub instead of BitBucket, and also update the hashes of all the ignition ports as apparently the archive generated by GitHub for releases are slightly different from the one generated by BitBucket.
5facdb8
to
ddd9e5e
Compare
Please resolve these regressions. Thanks. |
Hi @JackBoosY, the regressions are due to the fact that
It is possible to solve the issue, but it would require changes to the |
@traversaro Since vcpkg always chooses one repo to download source, I think we can delete the history in the baseline to solve this issue. Does this PR need to wait for #10859 to merge before merging? |
Great! There is any action needed on my side to do so?
No, they are completely independent. |
@ras0219-msft Could you remove Thanks. |
Unfortunately I am afraid that the problem applies to all the ports that use the |
Now that we're on new machines, we should be fine? hopefully? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks @traversaro :D |
Thanks a lot! |
As announced in https://community.gazebosim.org/t/important-gazebo-and-ignition-are-going-to-github/533, the ignition project repositories have been migrated from Bitbucket to GitHub.
This commit updates the ignition_modular_library helpers to use GitHub instead of Bitbucket,
and also update the hashes of all the ignition ports as apparently the archive generated by GitHub
for releases are slightly different from the one generated by Bitbucket.
Describe the pull request
What does your PR fix?
The PR does not fix any issue, but given that bitbucket will remove the original repos in June 2020, it will prevent future port failures.
Which triplets are supported/not supported? Have you updated the CI baseline?
No triplet support should he changed.
Does your PR follow the maintainer guide?
Yes. Furthermore the PR title follows the additional guidelines documented in [ignition-cmake0, ignition-math4] Add support for writing ports of Ignition Robotics libraries 🤖 #7781 (comment) .