[opencv4] Add GTK support for opencv4 portfile #10886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shelper
changed the title
|
Thanks for your PR! Can you please correct the Version field in the CONTROL file? And you should add |
|
|
|
Updated. |
LilyWangL
added
needs-feature-review
info:reviewed
|
LGTM, thanks @shelper :) I'm just gonna run it on the new PR CI pipeline. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Add GTK support for opencv4 portfile
What does your PR fix? Fixes issue #
with out this diff, the opencv4 built by vcpkg causes below error when calling GUI based functions like cv::imshow():
Rebuild the library with Windows, GTK+ 2.x or Carbon support. If you are on Ubuntu or Debian, install libgtk2.0-dev and pkg-config, then re-run cmake or configure script in function cvimshow
Which triplets are supported/not supported? Have you updated the CI baseline?
triplets tested: x64-linux (should also affect x86-linux)
no update to the CI baseline
Does your PR follow the maintainer guide?
It seems to comply with the guide