Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rtlsdr] Add new port #10901

Merged
merged 3 commits into from May 7, 2020
Merged

[rtlsdr] Add new port #10901

merged 3 commits into from May 7, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 19, 2020

  • What does your PR fix? Fixes issue #
    Nothing, this adds a new port for rtl-sdr - software that turns a Realtek RTL2832 based DVB dongle into a SDR receiver (https://osmocom.org/projects/rtl-sdr)

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    x86-windows and x64-windows are the only supported ones. Not yet.

  • Does your PR follow the maintainer guide?
    Yes.

@msftclas
Copy link

msftclas commented Apr 19, 2020

CLA assistant check
All CLA requirements met.

@JackBoosY
Copy link
Contributor

Hi @echesakov, thanks for this PR!
Please sign CLA first.

Thanks.

@ghost ghost marked this pull request as ready for review April 22, 2020 03:35
@ghost
Copy link
Author

ghost commented Apr 24, 2020

Please sign CLA first.

@JackBoosY I did, can you please re-run the ci?

@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

JackBoosY commented Apr 26, 2020

fatal: unable to connect to git.osmocom.org:
git.osmocom.org[0: 78.46.96.155]: errno=Unknown error

It seems that the network segment where the pipeline machine is located cannot access this address.

ports/rtlsdr/CONTROL Show resolved Hide resolved
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member

We firewall the git protocol at the moment (we allow only HTTP because we don't want a rogue PR to be able to turn our test fleet into spambots and that sort of thing). Is there an HTTP endpoint we can use or do we have to open that up?

@BillyONeal
Copy link
Member

#10980 will open that port

@ghost
Copy link
Author

ghost commented Apr 30, 2020

I have update the PR to use GitHub mirror https://github.com/osmocom/rtl-sdr

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil
Copy link
Contributor

Alright, this looks good! Thanks @echesakov :)

@strega-nil strega-nil merged commit 2459c7c into microsoft:master May 7, 2020
@ghost ghost deleted the rtlsdr branch May 9, 2020 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants