Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ompl] Fix patch apply error #10972

Merged
merged 4 commits into from
May 13, 2020
Merged

[ompl] Fix patch apply error #10972

merged 4 commits into from
May 13, 2020

Conversation

LilyWangL
Copy link
Contributor

Describe the pull request

@LilyWangL LilyWangL added the info:internal This PR or Issue was filed by the vcpkg team. label Apr 23, 2020
@LilyWangL LilyWangL marked this pull request as ready for review May 13, 2020 10:00
@JackBoosY JackBoosY added needs-further-review info:reviewed Pull Request changes follow basic guidelines labels May 13, 2020
@LilyWangL LilyWangL requested a review from strega-nil May 13, 2020 10:09
@strega-nil
Copy link
Contributor

Cool, LGTM! Thanks @LilyWangL :)

@strega-nil strega-nil merged commit e57b024 into microsoft:master May 13, 2020
strega-nil added a commit that referenced this pull request May 14, 2020
@strega-nil
Revert "[ompl] Fix patch apply error (#10972)"
d264465 
This reverts commit e57b024.
@strega-nil strega-nil mentioned this pull request May 14, 2020
Closed
@LilyWangL LilyWangL mentioned this pull request May 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

@strega-nil strega-nil Awaiting requested review from strega-nil

Assignees

@JackBoosY JackBoosY

Labels
info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LilyWangL @strega-nil @JackBoosY