Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metrohash] installation fix #10992

Merged
merged 1 commit into from
May 1, 2020
Merged

[metrohash] installation fix #10992

merged 1 commit into from
May 1, 2020

Conversation

kreuzerkrieg
Copy link
Contributor

Fixing paths and configuration

@LilyWangL LilyWangL self-assigned this Apr 24, 2020
@LilyWangL LilyWangL changed the title metrohash installation fix [metrohash] installation fix Apr 24, 2020
@LilyWangL
Copy link
Contributor

Thanks for your PR! Can you please correct the Version field in the CONTROL file? You can get more information from maintainer-guide.md.

@kreuzerkrieg
Copy link
Contributor Author

Thanks for your PR! Can you please correct the Version field in the CONTROL file? You can get more information from maintainer-guide.md.

Done

@kreuzerkrieg
Copy link
Contributor Author

Please do not merge, more changes to come

@kreuzerkrieg
Copy link
Contributor Author

Ok, looks good now
Please review

@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed waiting for response labels Apr 26, 2020
@strega-nil
Copy link
Contributor

LGTM! Thanks @kreuzerkrieg :)

@strega-nil strega-nil merged commit bdb7b81 into microsoft:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangL LilyWangL LilyWangL approved these changes

Assignees

@LilyWangL LilyWangL

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kreuzerkrieg @LilyWangL @strega-nil