-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[azure-iot-sdk-c] Fixed the CMake config export. #11017
Conversation
cc @ewertons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include(vcpkg_common_functions)
is no longer needed.
Could you please remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update
configure_file(${SOURCE_PATH}/LICENSE ${CURRENT_PACKAGES_DIR}/share/azure-iot-sdk-c/copyright COPYONLY)
as
configure_file(${SOURCE_PATH}/LICENSE ${CURRENT_PACKAGES_DIR}/share/${PORT}/copyright COPYONLY)
?
@NancyLi1013 Thanks for the feedback. I updated the recipe accordingly. @ewertons Let me know if my patch makes sense or not. Hope the patch can be folded back to the upstream. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include(vcpkg_common_functions)
is no longer needed.
Could you please remove this line?
Sorry, I didn't notice this before.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@NancyLi1013 updated. Thanks for the feedback. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
All features have passed on the following triplets:
|
Cool, thanks @seanyen :D |
The
azure-iot-sdk-c
port seems not to be really usable by using CMake config files.When one tries to consume the library by the following block:
Soon one will see this error when running CMake:
From my end, the problem is that
iothub_client
target is not exported from its CMake configs, but only${provisioning_libs}
get exported.This patch is attempting to correct this behavior.