-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ixwebsocket] update to 9.6.2 #11030
[ixwebsocket] update to 9.6.2 #11030
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vcpkg_test_cmake()
is deprecated.
Could you please remove it?
Needs to test the features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed there is only one options -DUSE_TLS=1
that is related with these features.
Besides this, I didn't see any operations to handle these features.
Could you please help make a simple clarification about how these features work?
Hi @NancyLi1013, I might not use the proper vcpkg terminology. I used curl as an example, as it's a bit similar to my app.
|
HI @bsergean For example, if we want to build with For feature |
Tried to build locally (on macOS) and it worked fine. |
… it is not building + I do not have access to this platform for testing
Why do you remove all features? |
I would like to simplify the port.
The features were only there to allocate different compatible SSL backed to each platform.
I would like to have SSL always enabled.
… On Apr 29, 2020, at 10:54 PM, NancyLi1013 ***@***.***> wrote:
Why do you remove all features?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#11030 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2O6UKEV2OCWLMJKI4PYTTRPEHCFANCNFSM4MQ6SBMA>.
|
@bsergean this seems to remove support for UWP; that's, imo, a non-starter. Can you add back in the dependency on |
I'd prefer making uwp works with OpenSSL, as it's easier for me to test and support. I'll see what I can do. Switching windows to openssl addresses a very common bug. I have tried enabling CI for uwp in here. The build fails with:
in this code, which works will all platform (and used to work ?). Not sure what's going on.
|
gai_strerror seems to return a wchar_t I configure with:
If you have any clue on what's going on @strega-nil I'm all ears :) |
I tried to find a MACRO that tells me if I'm building on uwp but I couldn't find it. I could convert the wstring to a string for uwp. |
@bsergean it looks like |
Cool those logs helped. I made one last change and everything seems to pass but the osx test, which looks like a flaky intermittent azure pipeline problem (failure to git clone). Next run should be good.
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
It seems good now except for osx pipeline that is not related with this PR. |
It looks like CI is happy again indeed, 'All checks have passed' says the robot. |
Yes, all checks have passed now. |
I have never tried to use different 'features' or tls implementations.
I think it would take a small change to the portfile.cmake to handle that.
For example on macOS, I could try to use mbedtls or openssl. I'll give that a try.
curl does something like that which I should probably do:
vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS
FEATURES
# Support HTTP2 TLS Download https://curl.haxx.se/ca/cacert.pem rename to curl-ca-bundle.crt, copy it to libcurl.dll location.
http2 USE_NGHTTP2
openssl CMAKE_USE_OPENSSL
mbedtls CMAKE_USE_MBEDTLS
ssh CMAKE_USE_LIBSSH2
tool BUILD_CURL_EXE
c-ares ENABLE_ARES
sspi CURL_WINDOWS_SSPI
brotli CURL_BROTLI
winssl CMAKE_USE_WINSSL
sectransp CMAKE_USE_SECTRANSP
INVERTED_FEATURES
non-http HTTP_ONLY
)
vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS
FEATURES
# Support HTTP2 TLS Download https://curl.haxx.se/ca/cacert.pem rename to curl-ca-bundle.crt, copy it to libcurl.dll location.
http2 USE_NGHTTP2
openssl CMAKE_USE_OPENSSL
mbedtls CMAKE_USE_MBEDTLS
ssh CMAKE_USE_LIBSSH2
tool BUILD_CURL_EXE
c-ares ENABLE_ARES
sspi CURL_WINDOWS_SSPI
brotli CURL_BROTLI
winssl CMAKE_USE_WINSSL
sectransp CMAKE_USE_SECTRANSP
INVERTED_FEATURES
non-http HTTP_ONLY
)
For me it would be something like that
vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS
FEATURES
openssl USE_OPENSSL
mbedtls USE_MBEDTLS
sectransp USE_SECTRANSP
)
… On May 18, 2020, at 7:18 PM, NancyLi1013 ***@***.***> wrote:
Yes, all checks have passed now.
I am going to test these features and will update the results once completed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#11030 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2O6UMB6UBLTTK6VOWRSMDRSHUBDANCNFSM4MQ6SBMA>.
|
…e the tls backend library
The check that fails looks like a ci problem, unrelated to the change, but I could be wrong -> https://dev.azure.com/vcpkg/public/_build/results?buildId=37180&view=results It failed right away after 4s trying to cleanup a scratch folder. |
All feature (except for
Note: Feature |
Alright, cool, thanks @bsergean :) This looks great |
Thanks ! Took me a while but I think I understand ports better now. |
Hello, Benjamin (@bsergean bsergean),
I only changed REF and SHA hash in portfile.cmake to following:
but there are probably larger differences between 9.x and 11.x versions |
There's an extra bit of cmake which needs to be added to deal with that but
I never figured it out myself.
Other ports probably have the cmake code snippet to copy paste. This is to
delete a file (or 2) that gets copied over, which vcpkg does not want. Or
maybe copy them in a different folder. vcpkg maintainers might know better.
…On Wed, Dec 30, 2020 at 5:14 AM Ludek Vodicka ***@***.***> wrote:
Hello, Benjamin ***@***.*** <https://github.com/bsergean> bsergean),
I tried to update IXWebsocket port to 11.0.4 version but I'm not sure how
to solve this vcpkg error:
The /lib/cmake folder should be merged with /debug/lib/cmake and moved to /share/ixwebsocket/cmake.
Please use the helper function `vcpkg_fixup_cmake_targets()`
The following cmake files were found outside /share/ixwebsocket. Please place cmake files in /share/ixwebsocket.
Q:/ExternalLibraries/vcpkg32/packages/ixwebsocket_x86-windows/lib/cmake/ixwebsocket/ixwebsocket-config-release.cmake
Q:/ExternalLibraries/vcpkg32/packages/ixwebsocket_x86-windows/lib/cmake/ixwebsocket/ixwebsocket-config.cmake
Q:/ExternalLibraries/vcpkg32/packages/ixwebsocket_x86-windows/debug/lib/cmake/ixwebsocket/ixwebsocket-config-debug.cmake
Q:/ExternalLibraries/vcpkg32/packages/ixwebsocket_x86-windows/debug/lib/cmake/ixwebsocket/ixwebsocket-config.cmake
The /debug/lib/cmake folder should be merged with /lib/cmake into /share/ixwebsocket
Found 3 error(s). Please correct the portfile:
Q:\ExternalLibraries\vcpkg32\ports\ixwebsocket\portfile.cmake
-- Performing post-build validation done
Error: Building package ixwebsocket:x86-windows failed with: POST_BUILD_CHECKS_FAILED
I only changed REF and SHA hash in portfile.cmake to following:
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO machinezone/IXWebSocket
REF v11.0.4
SHA512
fb24a628600cf28acdcaed5d2268f6a6e36baa1cc31f54287d91fb979fe375b20931fa9346153eaaf5a5d17fc6d87f06ca03ce12e401b83095c16919d35454ce
)
but there are probably larger differences between 9.x and 11.x versions
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11030 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC2O6UOKZKY4EJOZFA6ULELSXMRTRANCNFSM4MQ6SBMA>
.
|
Also I should make a new tag more recent than 11.0.4
On Wed, Dec 30, 2020 at 9:21 AM Benjamin Sergeant <bsergean@gmail.com>
wrote:
… There's an extra bit of cmake which needs to be added to deal with that
but I never figured it out myself.
Other ports probably have the cmake code snippet to copy paste. This is to
delete a file (or 2) that gets copied over, which vcpkg does not want. Or
maybe copy them in a different folder. vcpkg maintainers might know better.
On Wed, Dec 30, 2020 at 5:14 AM Ludek Vodicka ***@***.***>
wrote:
> Hello, Benjamin ***@***.*** <https://github.com/bsergean> bsergean),
> I tried to update IXWebsocket port to 11.0.4 version but I'm not sure how
> to solve this vcpkg error:
>
> The /lib/cmake folder should be merged with /debug/lib/cmake and moved to /share/ixwebsocket/cmake.
> Please use the helper function `vcpkg_fixup_cmake_targets()`
> The following cmake files were found outside /share/ixwebsocket. Please place cmake files in /share/ixwebsocket.
>
> Q:/ExternalLibraries/vcpkg32/packages/ixwebsocket_x86-windows/lib/cmake/ixwebsocket/ixwebsocket-config-release.cmake
> Q:/ExternalLibraries/vcpkg32/packages/ixwebsocket_x86-windows/lib/cmake/ixwebsocket/ixwebsocket-config.cmake
> Q:/ExternalLibraries/vcpkg32/packages/ixwebsocket_x86-windows/debug/lib/cmake/ixwebsocket/ixwebsocket-config-debug.cmake
> Q:/ExternalLibraries/vcpkg32/packages/ixwebsocket_x86-windows/debug/lib/cmake/ixwebsocket/ixwebsocket-config.cmake
>
> The /debug/lib/cmake folder should be merged with /lib/cmake into /share/ixwebsocket
> Found 3 error(s). Please correct the portfile:
> Q:\ExternalLibraries\vcpkg32\ports\ixwebsocket\portfile.cmake
> -- Performing post-build validation done
> Error: Building package ixwebsocket:x86-windows failed with: POST_BUILD_CHECKS_FAILED
>
> I only changed REF and SHA hash in portfile.cmake to following:
>
> vcpkg_from_github(
> OUT_SOURCE_PATH SOURCE_PATH
> REPO machinezone/IXWebSocket
> REF v11.0.4
> SHA512
> fb24a628600cf28acdcaed5d2268f6a6e36baa1cc31f54287d91fb979fe375b20931fa9346153eaaf5a5d17fc6d87f06ca03ce12e401b83095c16919d35454ce
> )
>
> but there are probably larger differences between 9.x and 11.x versions
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#11030 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AC2O6UOKZKY4EJOZFA6ULELSXMRTRANCNFSM4MQ6SBMA>
> .
>
|
-- Installing: /usr/local/include/ixwebsocket/IXWebSocketVersion.h
…-- Installing: /usr/local/include/ixwebsocket/IXSocketAppleSSL.h
-- Installing: /usr/local/lib/cmake/ixwebsocket/ixwebsocket-config.cmake
-- Installing:
/usr/local/lib/cmake/ixwebsocket/ixwebsocket-config-debug.cmake
You need something to uninstall the .cmake files
lots of port files have lines like that
file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/include)
Try to add this after that include line. And maybe remove the 2 files
explicitly. (ixwebsocket-config.cmake and ixwebsocket-config-debug.cmake).
file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/lib/cmake)
On Wed, Dec 30, 2020 at 9:22 AM Benjamin Sergeant <bsergean@gmail.com>
wrote:
Also I should make a new tag more recent than 11.0.4
On Wed, Dec 30, 2020 at 9:21 AM Benjamin Sergeant ***@***.***>
wrote:
> There's an extra bit of cmake which needs to be added to deal with that
> but I never figured it out myself.
>
> Other ports probably have the cmake code snippet to copy paste. This is
> to delete a file (or 2) that gets copied over, which vcpkg does not want.
> Or maybe copy them in a different folder. vcpkg maintainers might know
> better.
>
> On Wed, Dec 30, 2020 at 5:14 AM Ludek Vodicka ***@***.***>
> wrote:
>
>> Hello, Benjamin ***@***.*** <https://github.com/bsergean> bsergean),
>> I tried to update IXWebsocket port to 11.0.4 version but I'm not sure
>> how to solve this vcpkg error:
>>
>> The /lib/cmake folder should be merged with /debug/lib/cmake and moved to /share/ixwebsocket/cmake.
>> Please use the helper function `vcpkg_fixup_cmake_targets()`
>> The following cmake files were found outside /share/ixwebsocket. Please place cmake files in /share/ixwebsocket.
>>
>> Q:/ExternalLibraries/vcpkg32/packages/ixwebsocket_x86-windows/lib/cmake/ixwebsocket/ixwebsocket-config-release.cmake
>> Q:/ExternalLibraries/vcpkg32/packages/ixwebsocket_x86-windows/lib/cmake/ixwebsocket/ixwebsocket-config.cmake
>> Q:/ExternalLibraries/vcpkg32/packages/ixwebsocket_x86-windows/debug/lib/cmake/ixwebsocket/ixwebsocket-config-debug.cmake
>> Q:/ExternalLibraries/vcpkg32/packages/ixwebsocket_x86-windows/debug/lib/cmake/ixwebsocket/ixwebsocket-config.cmake
>>
>> The /debug/lib/cmake folder should be merged with /lib/cmake into /share/ixwebsocket
>> Found 3 error(s). Please correct the portfile:
>> Q:\ExternalLibraries\vcpkg32\ports\ixwebsocket\portfile.cmake
>> -- Performing post-build validation done
>> Error: Building package ixwebsocket:x86-windows failed with: POST_BUILD_CHECKS_FAILED
>>
>> I only changed REF and SHA hash in portfile.cmake to following:
>>
>> vcpkg_from_github(
>> OUT_SOURCE_PATH SOURCE_PATH
>> REPO machinezone/IXWebSocket
>> REF v11.0.4
>> SHA512
>> fb24a628600cf28acdcaed5d2268f6a6e36baa1cc31f54287d91fb979fe375b20931fa9346153eaaf5a5d17fc6d87f06ca03ce12e401b83095c16919d35454ce
>> )
>>
>> but there are probably larger differences between 9.x and 11.x versions
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <#11030 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/AC2O6UOKZKY4EJOZFA6ULELSXMRTRANCNFSM4MQ6SBMA>
>> .
>>
>
|
Is there any official way on how to ask maintainers to check it? Your library is great and I'm currently building it myself. But I'm trying to migrate all our compilation scripts to vcpkg but I have only limited knowledge of cmake and this is unfortunately also beyond my knowledge. PS: I can prepare new tag and hashs, it's not a problem. |
You were right, adding these two lines fixed the issue
Now the build proceeds correctly. I'm going to test it and if everything will be ok, I will create PR. |
You can use |
@NancyLi1013 Thanks! Victor Romero already helped me in another thread. |
Update the library to 9.5.0.
Notable changes: