[vcpkg] Correctly record default feature list in BinaryParagraphs. Fixes #10678. #11085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ras0219-msft
added
the
info:internal
cbezault
approved these changes
Apr 29, 2020
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When determining the precise list of features requested by a particular package reference (
FullPackageSpecin the code), the resolution algorithm must sometimes consult the list of default dependencies for the already installed package. This is because a reference such ascpprestsdk[compression]refers to the union ofcpprestsdk's declared default features and thecompressionfeature. In the case of depending upon an already installed package, we resolve defaults to the installed package's list until that package has been determined to need rebuilding.Unfortunately, we were silently not recording the list of defaults for packages, which caused all references to default features in already installed packages to misbehave and not actually require any features.
Fixes an underlying bug discovered in issue #10678. Users will need to rebuild all packages with default features to fully fix the problem. Requires also merging #11082 for a full resolution of @Ghabry's issue.
N/A
Yes