Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg/scripts] Fix ninja search path on windows and find binaries within vcpkg first #11105

Merged

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Apr 30, 2020

nothing more to add
closes #11133

@Neumann-A Neumann-A marked this pull request as draft May 1, 2020 23:11
First is for vcpkg fetch ninja
Second is for vcpkg_find_acquire_program
@Neumann-A Neumann-A marked this pull request as ready for review May 2, 2020 13:06
@LilyWangL LilyWangL self-assigned this May 6, 2020
@strega-nil
Copy link
Contributor

This LGTM, let's just rerun linux tests

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil
Copy link
Contributor

Thanks @Neumann-A :)

@strega-nil strega-nil merged commit 0bbf440 into microsoft:master May 6, 2020
@Neumann-A Neumann-A deleted the fix_ninja_in_vcpkg_find_acquire_program branch May 6, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vcpkg/ninja] VS CMake tools for Windows/Linux overwrite ninja from within VCPKG
3 participants