[vcpkg] Add nologo to windows toolchain

[Neumann-A]

closes #11144

There are still some linker logos in the log but i am apparently unable to find the correct cmake variable for it

[cenit]

just for symmetry reasons, do you maybe also need to add it to CMAKE_SHARED_LINKER_FLAGS_DEBUG and CMAKE_EXE_LINKER_FLAGS_DEBUG?

Also, why is there a /DEBUG flag in a *_RELEASE symbol? I realize it was already there, just questioning it in principle

[BillyONeal]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[strega-nil]

@Neumann-A why do you have two different styles of adding this flag? both set and string(APPEND? Is there a reason for it?

resolved

[Neumann-A]

@Neumann-A why do you have two different styles of adding this flag? both set and string(APPEND? Is there a reason for it?

_INIT flags versus normal flags. The set command completely overwrites the other variables and _INIT flags are used to initialize the normal values. I am just following the style of the other toolchains which use _INIT with string(APPEND)

vcpkg/scripts/toolchains/linux.cmake

Lines 12 to 22 in 305785b

	if(NOT _CMAKE_IN_TRY_COMPILE)
	string(APPEND CMAKE_C_FLAGS_INIT " -fPIC ${VCPKG_C_FLAGS} ")
	string(APPEND CMAKE_CXX_FLAGS_INIT " -fPIC ${VCPKG_CXX_FLAGS} ")
	string(APPEND CMAKE_C_FLAGS_DEBUG_INIT " ${VCPKG_C_FLAGS_DEBUG} ")
	string(APPEND CMAKE_CXX_FLAGS_DEBUG_INIT " ${VCPKG_CXX_FLAGS_DEBUG} ")
	string(APPEND CMAKE_C_FLAGS_RELEASE_INIT " ${VCPKG_C_FLAGS_RELEASE} ")
	string(APPEND CMAKE_CXX_FLAGS_RELEASE_INIT " ${VCPKG_CXX_FLAGS_RELEASE} ")
	string(APPEND CMAKE_SHARED_LINKER_FLAGS_INIT " ${VCPKG_LINKER_FLAGS} ")
	string(APPEND CMAKE_EXE_LINKER_FLAGS_INIT " ${VCPKG_LINKER_FLAGS} ")
	if(VCPKG_CRT_LINKAGE STREQUAL "static")

[strega-nil]

Ah, I see! why not modify the CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT and CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT then?

[Neumann-A]

Because it would require me to check the CMake source again to check how to change

    set(CMAKE_SHARED_LINKER_FLAGS_RELEASE "/nologo /DEBUG /INCREMENTAL:NO /OPT:REF /OPT:ICF ${VCPKG_LINKER_FLAGS}" CACHE STRING "")
    set(CMAKE_EXE_LINKER_FLAGS_RELEASE "/nologo /DEBUG /INCREMENTAL:NO /OPT:REF /OPT:ICF ${VCPKG_LINKER_FLAGS}" CACHE STRING "")

into the CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT|CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT variables if this is even possible. Since the last time I changed those variables I broke vcpkg (da0a154 9b44e47) I don't dare to touch them again for some time ;)

[cenit]

I'd trigger a full rebuild before merging, just in case ;)

[cenit]

@strega-nil (something that a toolchain modification should already do 😉)