Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wxwidgets] Apply fix to wxWidgets for copy and paste macOS #11178

Merged

Conversation

brad-anderson
Copy link
Contributor

Fixes copy and paste on macOS. See wxWidget's Trac #18553. Patch has long been applied wxWidgets master, this just backports it to the released development version. I've tested the fix locally and it works correctly.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

No changes though the fix only affects for macOS builds.

I hope so.

@msftclas
Copy link

msftclas commented May 5, 2020

CLA assistant check
All CLA requirements met.

@LilyWangL LilyWangL requested a review from PhoebeHui May 6, 2020 02:02
@PhoebeHui PhoebeHui changed the title Apply fix to wxWidgets for copy and paste macOS [wxwidgets] Apply fix to wxWidgets for copy and paste macOS May 6, 2020
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

The llvm failure doesn't related to this changes, the issue should be solved in baseline, it passed after rerun.

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label May 6, 2020
@strega-nil
Copy link
Contributor

Alright, this looks good to me! Thanks @brad-anderson :)

@strega-nil strega-nil merged commit f231421 into microsoft:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants