[uthenticode] Add new port

[woodruffw]

Adds a port for uthenticode, a cross-platform library for verifying Authenticode signatures.

• What does your PR fix? Fixes issue #

None.

• Which triplets are supported/not supported? Have you updated the CI baseline?

All default triplets should work.

• Does your PR follow the maintainer guide?

I believe so!

[BillyONeal]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[woodruffw]

Looking at the artifact logs, it looks like the problem might be some gcc/clang-style flags that are passed on Debug builds:

[1/3] "C:\PROGRA~2\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.25.28610\bin\Hostx64\x64\cl.exe"   /TP -DUTHENTICODE_VERSION=\"1.0.0\" -Duthenticode_EXPORTS -IC:\agent\_work\1\s\buildtrees\uthenticode\src\v1.0.0-925e2c938f\src\include -IC:\agent\_work\1\s\installed\x64-windows\include /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1    -Wall -Wextra -pedantic -Werror -fsanitize=address -std:c++17 /showIncludes /Fosrc\CMakeFiles\uthenticode.dir\uthenticode.cpp.obj /Fdsrc\CMakeFiles\uthenticode.dir\ /FS -c C:\agent\_work\1\s\buildtrees\uthenticode\src\v1.0.0-925e2c938f\src\uthenticode.cpp
FAILED: src/CMakeFiles/uthenticode.dir/uthenticode.cpp.obj 
"C:\PROGRA~2\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.25.28610\bin\Hostx64\x64\cl.exe"   /TP -DUTHENTICODE_VERSION=\"1.0.0\" -Duthenticode_EXPORTS -IC:\agent\_work\1\s\buildtrees\uthenticode\src\v1.0.0-925e2c938f\src\include -IC:\agent\_work\1\s\installed\x64-windows\include /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1    -Wall -Wextra -pedantic -Werror -fsanitize=address -std:c++17 /showIncludes /Fosrc\CMakeFiles\uthenticode.dir\uthenticode.cpp.obj /Fdsrc\CMakeFiles\uthenticode.dir\ /FS -c C:\agent\_work\1\s\buildtrees\uthenticode\src\v1.0.0-925e2c938f\src\uthenticode.cpp
Microsoft (R) C/C++ Optimizing Compiler Version 19.25.28614 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

cl : Command line error D8021 : invalid numeric argument '/Wextra'
ninja: build stopped: subcommand failed.

Weirdly enough, though, these don't cause issues on our own CI (which also does Debug builds). I'm making a patch release to exclude them on Windows to see if that helps.

See: trailofbits/uthenticode#24

[NancyLi1013]

LGTM now, thanks for this PR.

[woodruffw]

The current CI failure looks unrelated to this changeset.

[NancyLi1013]

Yes, the regressions for libqcow on Linux is not related to this PR. You can ignore it.
We will re run this once solved.

[strega-nil]

Alright cool! Thanks so much @woodruffw :D

[woodruffw]

Thanks a ton, all! Sent from mobile. Please excuse my brevity.

…

On May 8, 2020, at 5:35 PM, nicole mazzuca ***@***.***> wrote:  Merged #11199 into master. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.