[libpq] link libdl on linux #11223
Merged
[libpq] link libdl on linux #11223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
LilyWangL
approved these changes
May 8, 2020
|
Alright, fair enough. Thanks @mcgoo :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This adds
-dlto the link line on systems that havelibdl. Linking tolibpqon Ubuntu Focal fails to finddlopenand friends without it. (I copied the method to do this from theopenssl-unixport.)What does your PR fix? Fixes issue #
I did not create an issue. I did not find any open issues.
Which triplets are supported/not supported? Have you updated the CI baseline?
This should not change triplet support if working correctly. The libpq port was already building on Linux and still is. CI baseline already expects it to build.
Does your PR follow the maintainer guide?
Yes.