Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ignition-math6] Add new port 🤖 #11232

Merged
merged 2 commits into from
May 8, 2020

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented May 7, 2020

  • What does your PR fix?

    • This PR adds a new port for the new major version of the ignition-math library.
  • Which triplets are supported/not supported?

    • All tested triplet should be supported
  • Does your PR follow the maintainer guide?

    • I hope.

As discussed in #7781, different major version of ignition robotics libraries (https://ignitionrobotics.org/) can be installed side by side, so each new major version is added as a new port.

In particular, ignition-math6 is a dependency for Gazebo 11 (http://gazebosim.org/blog/gazebo11) and for Ignition Robotics Citadel (that contains Ignition Gazebo 3, see https://www.openrobotics.org/blog/2019/12/11/ignition-citadel-released).

To fix the build on arm64-windows, this PR also bumps the ignition-cmake2 version to 2.2.0, that contains a fix for arm64-windows (https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-cmake/pull-requests/168/page/1).

@traversaro traversaro changed the title [ignition-math6] Add new port [ignition-math6] Add new port 🤖 May 7, 2020
@traversaro
Copy link
Contributor Author

The Linux CI is failing on the libqcow port with this error:

-- Note: libqcow only supports dynamic library linkage. Building dynamic library.
-- Downloading https://github.com/libyal/libqcow/releases/download/20191221/libqcow-alpha-20191221.tar.gz...
-- Downloading https://github.com/libyal/libqcow/releases/download/20191221/libqcow-alpha-20191221.tar.gz... Failed. Status: 22;"HTTP response code said error"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:175 (message):
      
      Failed to download file.
      If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY environment
      variables to "https://user:password@your-proxy-ip-address:port/".
      Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/issues

Call Stack (most recent call first):
  ports/libqcow/portfile.cmake:8 (vcpkg_download_distfile)
  scripts/ports.cmake:90 (include)

That I guess it is both unrelated and a network flake.

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label May 8, 2020
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for this PR @traversaro.

@strega-nil
Copy link
Contributor

Hey, this looks great! Thanks @traversaro

@strega-nil strega-nil merged commit 57e65ee into microsoft:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants