Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Turn on tests in CI. #11239

Merged
merged 15 commits into from
May 14, 2020
Merged

[vcpkg] Turn on tests in CI. #11239

merged 15 commits into from
May 14, 2020

Conversation

BillyONeal
Copy link
Member

No description provided.

@BillyONeal BillyONeal added info:internal This PR or Issue was filed by the vcpkg team. category:infrastructure Pertaining to the CI/Testing infrastrucutre labels May 8, 2020
@BillyONeal BillyONeal self-assigned this May 8, 2020
@BillyONeal BillyONeal force-pushed the ci_testing branch 7 times, most recently from 21cce76 to a66b5d8 Compare May 8, 2020 03:59
@BillyONeal
Copy link
Member Author

Example failure: https://dev.azure.com/vcpkg/public/_build/results?buildId=36291&view=logs&j=657c9d73-2672-59f2-b256-fdad23962c37&t=db425a18-2931-5c88-9ee2-7d283bf797fd

@BillyONeal BillyONeal marked this pull request as ready for review May 8, 2020 04:01
@BillyONeal
Copy link
Member Author

I filed #11240 to track symlink tests not being able to run in our CI system.

@strega-nil
Copy link
Contributor

I would prefer it if we just ignore the bootstrap scripts for this purpose; there's no reason to not just build with CMake, IMO.

@BillyONeal
Copy link
Member Author

I would prefer it if we just ignore the bootstrap scripts for this purpose; there's no reason to not just build with CMake, IMO.

This is a policy question vis a vis version of cmake we work with. The version of cmake that is on the system is much older than the one bootstrap will install. Do we want to work with the version of cmake that comes with ubuntu 18.04?

@strega-nil
Copy link
Contributor

Hmm, fair point. We could use pip to install an up to date version tho

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal BillyONeal added the category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) label May 12, 2020
@BillyONeal
Copy link
Member Author

@ras0219 @ras0219-msft Assigning this to you because those test failures are preexisting and I think you're the only one from around when that code was written.

strega-nil
strega-nil approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions, but this looks good :)

@strega-nil
Copy link
Contributor

@BillyONeal PR for change ideas at BillyONeal#1

@BillyONeal
Copy link
Member Author

@strega-nil Merged; also feel free to just push into it if you want :)

@BillyONeal
Copy link
Member Author

Interestingly one of the failing tests says "// TODO: order here may change but A < X, and B anywhere" -- maybe we are seeing differences in std::sort between the standard libraries here?

BillyONeal and others added 14 commits May 13, 2020 23:10
@BillyONeal
[vcpkg] Turn on tests for Linux and OSX.
0c603f1
@BillyONeal
[vcpkg] Add Windows tests to CI.
00472bc
@BillyONeal
[vcpkg] Fix bogus null termination check in unicode decoding.
746b362
@BillyONeal
[vcpkg] Back off symlink message to stdout instead of stderr to avoid…
7cd2c50 
… failing CI over this.
@BillyONeal @strega-nil
Deduplicate CMAKE_BUILD_TYPE from Nicole.
1bd649d 
Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
@BillyONeal
Fix static analysis warnings.
88031a5 
CMakeLists.txt: Turn on /analyze when development warnings are on.
catch.hpp: See submitted upstream: catchorg/Catch2#1925
downloads.cpp: PREfast can't see that check_exit is noreturn when f == nullptr.
files.cpp: PREfast detected this bogus both sides of the && testing the same thing.
strings.cpp: Same as the catch issue, isspace needs to be given unsigned.
system.process.cpp: suppress ownership transfer warning about process_info, and make ProcessInfo ensure handles are closed.
build.cpp: PREfast still doesn't understand check_exit
commands.integrate.cpp: More bad <ctype.h> calls.
@BillyONeal
Workaround missing _Analysis_assume_ on Linux and MacOS.
8f55c9a
@strega-nil @BillyONeal
minor fixes
b22c974
@BillyONeal
De-allowAppleClang as suggested by Nicole.
76f5b79
@BillyONeal
Add sal.h to restore _Analysis_assume_ correctness.
bc3f81a
@BillyONeal
Fix -Werror=reorder on Linux.
fd3419c
@BillyONeal
Delete unused sort bits from json.h.
6e98dcf
@BillyONeal
Fix set_environment_variable which was still broken 2 tries in.
7bfb45b
@BillyONeal
Use map rather than unordered_map in places to give consistent topolo…
57827aa 
…gical package sorting across standard library implementations.
@BillyONeal
Copy link
Member Author

Map fixed it (but Linux is on the floor atm)

@BillyONeal
Copy link
Member Author

/azp run

@BillyONeal BillyONeal merged commit 5504dfa into microsoft:master May 14, 2020
@BillyONeal BillyONeal deleted the ci_testing branch May 14, 2020 19:49
@simogasp simogasp mentioned this pull request May 14, 2020
Closed
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request May 15, 2020
@Jimmy-Hu
Merge pull request #211 from microsoft/master
fd0b050 
[vcpkg] Turn on tests and PREfast in CI, and fix tests to pass. (microsoft#11239)
strega-nil added a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
@BillyONeal @strega-nil
[vcpkg] Turn on tests and PREfast in CI, and fix tests to pass. (micr…
45ac07a 
…osoft#11239)

Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strega-nil strega-nil strega-nil approved these changes

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

Assignees

@BillyONeal BillyONeal

Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BillyONeal @strega-nil @ras0219-msft