[libtorrent] add iconv feature on windows and clean up portfile #11257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
suggested changes
May 9, 2020
FranciscoPombal
force-pushed
the
improve_libtorrent
branch
from
643fd5e
to
8e12908
Compare
JackBoosY
approved these changes
May 11, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@strega-nil Could you please review this PR? Thanks. |
strega-nil
reviewed
May 11, 2020
FranciscoPombal
force-pushed
the
improve_libtorrent
branch
from
8e12908
to
744ae0e
Compare
FranciscoPombal
force-pushed
the
improve_libtorrent
branch
from
744ae0e
to
ed07901
Compare
strega-nil
approved these changes
May 12, 2020
|
Thanks @FranciscoPombal, this is awesome :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
iconvfeature on Windows. Also prevents Windows builds from accidentally picking upIconvwith CMake's built-inFindIconv, which causes builds of software that uses libtorrent to fail linking.export.hppcustomizations. They are not needed anymore. Tested with the method mentioned in [libtorrent] Fix linkage issues for dynamic builds #7345 (comment) with all standard windows triplets, and on linux - no linking failures.vcpkg_fixup_cmake_targets, now target directory uses actual package name (capitalization was wrong)Which triplets are supported/not supported? Have you updated the CI baseline?
No change in triplet support.
Does your PR follow the maintainer guide?
Yes.