Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libgo] Update to 3.1 #11263

Merged
merged 8 commits into from
May 18, 2020

Conversation

NancyLi1013
Copy link
Contributor

libgo current version 2.8 is broken since execution_context.hpp doesn't exist in boost-context modular of boost 1.72.

So I update to the latest version 3.1 to keep it work.

Fixes #11077

Note: No feature needs to test.

@NancyLi1013 NancyLi1013 added the info:internal This PR or Issue was filed by the vcpkg team. label May 9, 2020
@NancyLi1013 NancyLi1013 marked this pull request as ready for review May 11, 2020 13:58
@NancyLi1013
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor Author

The regressions on x64-uwp and arm-uwp are like this:

4>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VC\v160\Microsoft.CppBuild.targets(1781,5): error MSB8024: Using static version of the C++ runtime library is not supported.

It seems that the current version 3.1 doesn't support uwp. I will try to disable it until the new version can support uwp.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label May 18, 2020
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes! Thanks @NancyLi1013, I'm going to merge after CI run.

ports/libgo/portfile.cmake Outdated Show resolved Hide resolved
ports/libgo/portfile.cmake Outdated Show resolved Hide resolved
@strega-nil strega-nil merged commit 3f7bee6 into microsoft:master May 18, 2020
@NancyLi1013
Copy link
Contributor Author

Thanks for your further review and update. @strega-nil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libgo] build failure
3 participants