[vcpkg] Do not build the metrics uploader with MSBuild when metrics are disabled #11368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhoebeHui
changed the title
JackBoosY
approved these changes
May 18, 2020
JackBoosY
added
needs-feature-review
info:reviewed
|
Cools, thanks much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR skips building the vcpkgmetricsuploader project when
-disableMetricsis used during bootstrapping with MSBuild as requested in the issue mentioned above. It adds a condition to the project file and skips copying the executable.Which triplets are supported/not supported? Have you updated the CI baseline?
Does your PR follow the maintainer guide?
Yes.