Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nlopt] Enable UWP support #11398

Merged
merged 1 commit into from
May 18, 2020
Merged

[nlopt] Enable UWP support #11398

merged 1 commit into from
May 18, 2020

Conversation

rickertm
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

Enables UWP support for package nlopt by backporting upstream commit stevengj/nlopt@004f415.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

The CI baseline is updated to remove arm-uwp=fail and x64-uwp=fail for this package.

Yes.

@NancyLi1013 NancyLi1013 self-assigned this May 18, 2020
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label May 18, 2020
@NancyLi1013
Copy link
Contributor

Hi @rickertm
Thanks for this PR.
LGTM now.

@strega-nil
Copy link
Contributor

Alright, this LGTM! Thanks @rickertm :)

@strega-nil strega-nil merged commit 87b2ae5 into microsoft:master May 18, 2020
@rickertm rickertm deleted the patch-nlopt-uwp branch May 20, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickertm @NancyLi1013 @strega-nil