-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infoware] Add port of infoware library #11410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also update the hash value?
The CI test failures:
File does not have expected hash:
File path: [ C:/agent/_work/1/s/downloads/temp/ThePhD-infoware-v0.5.3.tar.gz ]
Expected hash: [ 64a4f0b1027a20bf9c90bf99d638947cb1c0d6bad1b22c8b0403713c5e2c69756435906996b154989f9eaa41e5d55743d7bf5ef51f7bbf8d99eae94d29af1b2c ]
Actual hash: [ 217bb9332214d823445e19f2c465199536e89a36faccea8cb72f8dd41a177e1739969d131ad25d1878e688a3a6cc1290c2125ef9d2205ad4fd334b24b27d491a ]
The file may have been corrupted in transit. This can be caused by
proxies. If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY
environment variables to
"https://user:password@your-proxy-ip-address:port/".
…to do a new revision just for saving distribution information
I, uh. Seem to have irreversibly ruined my git commit. One moment. ;; |
@ThePhD, the CI test with following triplet, does it expect? could you please take a look? infoware:x64-uwp |
I was not expecting this: there seems to be a specific problem with MSBuild on these platforms and building the tool to generate PCI data? Works fine with Ninja; I'll try to fix it up for MSBuild. Sorry about the failed tests...! |
I actually don't understand what's going on in vcpkg in these cases. I can build for the platforms listed as failures independently outside of vcpkg, invoking the CMake build and install with either Ninja or MSBuild just fine. But inside of vcpkg, I get errors like these:
I sincerely am not sure how to handle this. Maybe I should just disable the |
@ThePhD For UWP, I have no idea what's wrong; I would just set it as For |
Is the right thing to do |
Also, I think the x64_osx pipeline is broken...! |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Currently we add the follow code when it unsupport some arch or platform.
@ThePhD, currently we don't need add unsupport triplet to ci baseline file, since we already have 'Support' field, could you add the warnning message for users by 'vcpkg_fail_port_install(ON_ARCH "arm" ON_TARGET "uwp")'? |
@ThePhD Thanks for your contribution! |
Oh, nice, thanks for adding that function to the PR, glad it seems to all work now!! |
Thanks for the PR! |
* Improved infoware and portfile port * Add a note for why we do this. * Add vcpkg_fail_port_install call requested by @PhoebeHui Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
* Improved infoware and portfile port * Add a note for why we do this. * Add vcpkg_fail_port_install call requested by @PhoebeHui Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
This pull request adds a port for the C++ infoware library.
All triplets should be supported, with both dynamic and static builds available.
I could not find additional examples of CI that needed to change or more. The version of infoware being targeted by vcpkg should be 0.5.3.